Skip to content

feat(linux-grid): keep the row numbers in view while the columns scroll sideways - #4110

Merged
datlechin merged 16 commits into
TableProApp:mainfrom
sedax90:feat/linux-grid-pinned-row-numbers
Nov 9, 2026
Merged

datlechin merged 16 commits into
TableProApp:mainfrom
sedax90:feat/linux-grid-pinned-row-numbers

Conversation

@sedax90

@sedax90 sedax90 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Keep row numbers and pending-change icons visible while columns scroll sideways.
  • Use one native row layout, selection model and scrolled window. The fixed gutter draws the same native cells and preserves selection, dragging, keyboard navigation and accessibility.
  • Preserve row and header menus, stripes, tooltips and right-to-left layout. Match row heights after font and spacing changes.

Test plan

  • 22 gutter widget tests cover pixel equality, both scroll axes, 1,000-row alignment, fonts, inline editors, menus, selection, dragging, keyboard focus and stationary header hover.
  • CI app tests passed: 3,066 at normal scale and 494 in the scale-2 suite. Build, formatting and all Clippy configurations passed.
  • Codex review passed. Captured and checked the scrolled table in light and dark themes at the pushed head.

Screenshots

After: columns are scrolled sideways to show project managers, departments and later fields while row numbers remain at the left edge.

Light Dark
Before Before, light Before, dark
After After, light After, dark

cozyGarage added a commit to cozyGarage/BookiE that referenced this pull request Nov 8, 2026
…2519)

<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## Change

Fixes #2498. Browse and SQL-result grids show a leading `#` row-number
gutter that stays put while data columns scroll horizontally. Vertical
scroll, selection and menus stay on the single `ColumnView` (TablePro
[#4110](TableProApp/TablePro#4110) overlay /
pinned-numbers approach). Freezing leading data columns remains out of
scope (#2208 / ADR 0033).

Lane: UX.

## Release note

```
Release-Note: Added: Result and browse grids keep a sticky row-number gutter while columns scroll sideways.
```

## Reproduction and regression proof

**Given** a wide browse or SQL result grid  
**When** the user scrolls horizontally  
**Then** 1-based row numbers stay visible at the leading edge, and
selecting a data row still selects that row.

Before: grids had no row-number column.

Regression coverage:

-
`ui::grid::row_number_column::tests::page_offsets_and_drafts_choose_the_displayed_number`
(unit)
-
`ui::grid::row_number_tests::result_grids_number_rows_from_one_and_keep_the_gutter_after_horizontal_scroll`
(gtk-widgets)
-
`ui::grid::row_number_tests::browse_offset_shifts_the_leading_row_numbers`
(gtk-widgets)

## Validation

- Tested commit: tip of `cursor/sticky-row-number-gutter-9087` (includes
merge of latest `linux`)
- Local: `check-function-size`, `check-comment-lines`,
`check-file-size`, `inventory-ignored-tests.py --check` — ok
- Unrun / blocked locally: full `scripts/preflight.sh` (`xgettext`
missing); `bookie-app` / gtk-widgets (system glib 2.80 < 2.88)
- Required acceptance checks: pending on the PR head (Actions may be
billing-locked; do not burn re-runs)
- Applicable layers: gtk-unit / gtk-widgets (and preflight non-GTK
guards in CI)

<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-ca6827d4-a6cc-5949-8f84-1f2652829087?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-ca6827d4-a6cc-5949-8f84-1f2652829087&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
@datlechin
datlechin added this pull request to the merge queue Nov 9, 2026
@datlechin
datlechin merged commit 1d20512 into TableProApp:main Nov 9, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants