Skip to content

feat(linux-browse): one bottom bar for a table tab's Structure view - #4111

Merged
datlechin merged 32 commits into
TableProApp:mainfrom
sedax90:feat/linux-browse-structure-one-bar
Nov 11, 2026
Merged

datlechin merged 32 commits into
TableProApp:mainfrom
sedax90:feat/linux-browse-structure-one-bar

Conversation

@sedax90

@sedax90 sedax90 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Give a table tab one bottom bar in Structure. Keep its commands, pending state and Save beside the Data / Structure switch.
  • Save and Refresh follow the selected view, including with focus on the shared bar. Structure commands keep their own draft and save state.
  • Compact tabs keep Save and the saving indicator visible, with Discard, Stop Saving and Drop Table in More. Standalone Structure tabs retain their own bar.
  • The view switch keeps its full names. Below 1050 sp, Columns, Export and the page size move to a More Actions menu, so a 1200 px window no longer cuts "Data" and "Structure".
  • Builds on feat(linux-browse): switch a table tab between Data and Structure from its bottom bar #4108, now on main.

Screenshots

Light Dark
Before Before, light Before, dark
After After, light After, dark

Test plan

  • Extend selected-view tests to cover shortcuts from docked controls, compact commands and save states.
  • Check the compact bar width and restoration of the wide bar.
  • Check that standalone Structure tabs retain their command bar.
  • Add the_view_switch_keeps_its_names_in_a_1200_px_window: full names and a bar that fits at 1200 px and at the 920 px a 1200 px window leaves beside the sidebar, in Data and Structure.
  • the_bottom_bar_offers_the_column_chooser now opens at 1200 px instead of 1000 px, since the full Data bar no longer shows below 1050 sp.
  • Full build, lint and test verification runs in CI.

…ucture-switch

# Conflicts:
#	linux/crates/app/src/ui/browse_tab/tests/mod.rs
#	linux/crates/app/src/ui/workspace/tab_factory.rs
#	linux/crates/app/src/ui/workspace/tests/close_tab.rs
#	linux/crates/app/src/ui/workspace/workspace_tabs.rs
#	linux/data/resources/ui/browse-tab.ui
…ucture-switch

# Conflicts:
#	linux/crates/app/src/ui/browse_tab/data_handlers.rs
#	linux/crates/app/src/ui/browse_tab/data_input.rs
#	linux/crates/app/src/ui/browse_tab/tests/mod.rs
TableProApp#4113 and TableProApp#4134 landed one after the other, and main stopped compiling at this call.
…ux-browse-structure-one-bar

# Conflicts:
#	linux/crates/app/src/ui/browse_tab/tests/mod.rs
…ns, Export and the page size to a menu first
…ucture-one-bar

# Conflicts:
#	linux/crates/app/src/ui/browse_tab/mod.rs
#	linux/crates/app/src/ui/structure_tab/imp.rs
#	linux/crates/app/src/ui/structure_tab/structure_actions.rs
…ucture-one-bar

# Conflicts:
#	linux/crates/app/src/ui/browse_tab/layout.rs
@datlechin
datlechin enabled auto-merge (squash) November 11, 2026 00:02
@datlechin
datlechin merged commit 8295363 into TableProApp:main Nov 11, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants