Skip to content

feat(linux-sidebar): rename and delete a favorite from the list - #4115

Merged
datlechin merged 15 commits into
TableProApp:mainfrom
sedax90:feat/linux-favorites-rename-delete
Nov 9, 2026
Merged

datlechin merged 15 commits into
TableProApp:mainfrom
sedax90:feat/linux-favorites-rename-delete

Conversation

@sedax90

@sedax90 sedax90 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Rename and delete favorites from a row menu, a secondary click, or the keyboard. Menu and Shift+F10 open the selected row's menu; F2 renames and Delete asks to delete.
  • Confirm deletion, reject blank names, and explain storage failures. Keep confirmed writes running after the window closes.
  • Resolve actions by saved-query ID and refresh every saved-query view through the shared store from feat(linux-sidebar): add a Favorites scope listing the connection's saved queries #4114.

Screenshots

Light Dark
Before Before, light Before, dark
After: row menu After, light After, dark
After: rename Rename, light Rename, dark
After: delete confirmation Delete confirmation, light Delete confirmation, dark

Test plan

  • Widget tests cover row menus, keyboard modifiers, context menus, reordering, and stale targets.
  • Storage-backed widget tests cover confirmation, blank names, duplicate names, held writes, and completion after the window closes.
  • The shutdown test tracks the query write’s own hold token independently of window cleanup.
  • Fast checks passed both Clippy configurations, the build, all eight Meson suites, and all seven Secret Service tests.
  • Supply-chain checks and both Flatpak builds passed on 8dc5815.
  • Built 8dc5815 in the Linux dev container. Checked the favorite row menu, rename, and delete confirmation in light and dark themes with a scratch SQLite database.

@datlechin
datlechin added this pull request to the merge queue Nov 8, 2026
@datlechin
datlechin removed this pull request from the merge queue due to a manual request Nov 9, 2026
@datlechin
datlechin merged commit 50fa1b2 into TableProApp:main Nov 9, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants