Skip to content

feat(core-storage): keep folders, keywords and favourite tables and databases beside saved queries - #4116

Merged
datlechin merged 7 commits into
TableProApp:mainfrom
sedax90:feat/core-favorites-storage
Nov 9, 2026
Merged

datlechin merged 7 commits into
TableProApp:mainfrom
sedax90:feat/core-favorites-storage

Conversation

@sedax90

@sedax90 sedax90 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Store saved-query folders, keywords and positions, plus favorite tables and databases, in the shared history database.
  • Keep ordering within each connection and folder. New queries append; replacements preserve identity and filing. Folder names and keywords use Unicode-aware uniqueness checks.
  • Publish committed changes through one shared feed and read queries with their folders in one snapshot. Folder deletion keeps query text and removes the same folder IDs from upgrade copies.
  • Add a migration for existing positions. Keep prior migrations unchanged and preserve the database copy made before an upgrade.

Test plan

  • Added 27 regression tests for ordering, concurrent writes, Unicode names, snapshots, notifications, failed purges, migration upgrades and recovery copies.
  • Updated migrator_embeds_every_migration and the open-schema test to expect three migrations.
  • Formatting and banned-word checks pass. Independent Codex review found no issues.
  • Build, Clippy and test verification run on CI. No UI change in this PR.

@datlechin
datlechin added this pull request to the merge queue Nov 9, 2026
…torage

# Conflicts:
#	core/crates/storage/src/query_history/mod.rs
#	core/crates/storage/src/saved_queries/mod.rs
@datlechin
datlechin merged commit 89064c1 into TableProApp:main Nov 9, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants