Skip to content

feat(linux-workspace): keep the sidebar toggle in the header while the sidebar shows - #4117

Merged
datlechin merged 3 commits into
TableProApp:mainfrom
sedax90:feat/linux-sidebar-toggle-always
Nov 9, 2026
Merged

datlechin merged 3 commits into
TableProApp:mainfrom
sedax90:feat/linux-sidebar-toggle-always

Conversation

@sedax90

@sedax90 sedax90 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Keep the sidebar toggle visible so it can close and reopen the sidebar in wide and narrow windows.
  • Keep its pressed state, accessible name and F9 action in sync with the sidebar.

Screenshots

Light Dark
Before: no button with the sidebar in view Before, light Before, dark
After After, light After, dark

Test plan

  • Expanded the_sidebar_toggle_is_always_in_the_header to cover clicks, action activation, pressed state and accessibility in both layouts. It replaces sidebar_toggle_visible_only_when_collapsed_or_hidden, whose behavior changes on purpose.
  • cargo fmt --all --check passed. Codex review found no defects.
  • CI passed. Built the pushed head in the Linux dev container and checked the sidebar toggle in light and dark modes.

@datlechin
datlechin added this pull request to the merge queue Nov 9, 2026
@datlechin
datlechin merged commit 66570d1 into TableProApp:main Nov 9, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants