Skip to content

fix(linux-editor): keep the query in view when the results are dragged up - #4120

Merged
datlechin merged 3 commits into
TableProApp:mainfrom
sedax90:fix/linux-editor-keeps-its-height
Nov 9, 2026
Merged

datlechin merged 3 commits into
TableProApp:mainfrom
sedax90:fix/linux-editor-keeps-its-height

Conversation

@sedax90

@sedax90 sedax90 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Keep query lines visible when the results divider is dragged upward.
  • Let GTK enforce the editor's 120 px content minimum and preserve the results pane's minimum.
  • Keep the divider movable between both limits, including with a long query or a short window.

Test plan

  • the_divider_keeps_the_editor_in_view now checks allocated widget heights at both limits, long SQL, and a shorter window.
  • Formatting, diff and writing checks passed. CI is green at c71c0e020: Clippy, 8 Meson test suites, 7 Secret Service tests, all integration jobs and the Flatpak build pass.
  • Built the pushed head in the Linux dev container. Dragged the divider to its upper limit and checked the query stays visible in light and dark modes.

Screenshots

The divider dragged to the top.

Light Dark
Before: the query is gone Before, light Before, dark
After: it stops at the editor's lines After, light After, dark

@datlechin
datlechin added this pull request to the merge queue Nov 9, 2026
@datlechin
datlechin merged commit 3d84c78 into TableProApp:main Nov 9, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants