Skip to content

feat(linux-workspace): add Save Changes to the header - #4126

Merged
datlechin merged 12 commits into
TableProApp:mainfrom
sedax90:feat/linux-header-save
Nov 10, 2026
Merged

datlechin merged 12 commits into
TableProApp:mainfrom
sedax90:feat/linux-header-save

Conversation

@sedax90

@sedax90 sedax90 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add Save Changes beside New Query for table rows, table structure and editable query results.
  • Follow each tab's native save state, including the first inline edit and a save in progress. Switching tabs or sessions keeps the button in sync.
  • Use the existing commit, review and write path. SQL file saving keeps its current Ctrl+S behavior.

Screenshots

Light Dark
Before rewrite: clean tab Off, light Off, dark
Before rewrite: edited tab On, light On, dark
After: clean tab Clean tab, light Clean tab, dark
After: pending edit After, light After, dark

Test plan

  • Five widget cases cover inline commit and an actual write, sidebar and session selection, structure state and editable query results.
  • Replace the contributor's direct tracker test with widget-driven coverage. Check the accessible name and shortcut metadata, plus action removal on shutdown.
  • cargo fmt --all --check, diff whitespace and XML parsing passed. Codex review is clean. Compilation and test execution run in CI.

@datlechin
datlechin added this pull request to the merge queue Nov 9, 2026
# Conflicts:
#	linux/crates/app/src/ui/workspace/tests/close_tab.rs
#	linux/crates/app/src/ui/workspace/workspace_actions.rs
#	linux/crates/app/src/ui/workspace/workspace_shell.rs
#	linux/crates/app/src/ui/workspace/workspace_shell_imp.rs
#	linux/data/resources/ui/workspace-shell.ui
# Conflicts:
#	linux/crates/app/src/ui/browse_tab/imp.rs
#	linux/crates/app/src/ui/workspace/tests/close_tab.rs
@datlechin
datlechin merged commit 215fe09 into TableProApp:main Nov 10, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants