Skip to content

feat(linux-grid): add Highlight Rules to colour the rows and cells that meet a condition - #4127

Merged
datlechin merged 14 commits into
TableProApp:mainfrom
sedax90:feat/linux-highlight-rules
Nov 10, 2026
Merged

datlechin merged 14 commits into
TableProApp:mainfrom
sedax90:feat/linux-highlight-rules

Conversation

@sedax90

@sedax90 sedax90 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add Highlight Rules to table and query results: colour rows or cells that meet a column condition. The first matching rule wins; a cell rule takes priority over a row rule.
  • Edit and reorder rules in an adaptive dialog with labelled controls. The narrow-window menu keeps the editor available. Missing and duplicate column names remain distinct.
  • Compare numbers without rounding and match full values with bounded wildcard matching. Pending edits update the colours; selection keeps its accent, and accessible descriptions announce highlights.
  • Keep query-result rules while switching pages and rebuilding results. Table rules persist across restarts in feat(linux-grid): keep a table's highlight rules across restarts #4129.

Screenshots

Light Dark
Before Before, light Before, dark
After: grid After, light After, dark
After: rules dialog Rules dialog, light Rules dialog, dark

Test plan

  • Evaluator tests cover exact large numbers, typed equality, wildcard patterns, NULL, unavailable values, duplicate columns, full values and rule priority.
  • Widget tests cover editing, ordering, column refresh, released dialogs, highlight descriptions, result eviction, rebuild, new-run clearing and rendering before cells are parented.
  • The old popover editing test is replaced by dialog behavior tests. Text equality now keeps numeric-looking text distinct; numeric equality keeps its existing behavior.
  • CI passed, including all Clippy variants, eight Meson suites, 2x scale widget tests, seven keyring tests and database integrations. Local formatting and writing checks passed.

@datlechin
datlechin added this pull request to the merge queue Nov 9, 2026
…rules

# Conflicts:
#	linux/crates/app/src/ui/data_grid/grid_cell.rs
#	linux/crates/app/src/ui/data_grid/tests/cells.rs
#	linux/crates/app/src/ui/editor/results_pane.rs
#	linux/data/resources/style.css
#	linux/data/resources/ui/browse-tab.ui
#	linux/data/resources/ui/results-pane.ui
…rules

# Conflicts:
#	linux/data/resources/ui/browse-tab.ui
…rules

# Conflicts:
#	linux/crates/app/src/ui/data_grid/grid_cell.rs
@datlechin
datlechin merged commit dcf49a9 into TableProApp:main Nov 10, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants