Skip to content

fix(linux-workspace): select a moved query tab's database row when its tab is selected - #4132

Merged
datlechin merged 6 commits into
TableProApp:mainfrom
sedax90:feat/linux-sidebar-follows-tab
Nov 9, 2026
Merged

datlechin merged 6 commits into
TableProApp:mainfrom
sedax90:feat/linux-sidebar-follows-tab

Conversation

@sedax90

@sedax90 sedax90 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Select the database row of the query tab in front. Keep the owning connection selected while that database is unavailable, or when the engine lists databases as schemas.
  • Follow the same catalog session for completion and sidebar selection. Handle sibling-owned tabs and a connection opened in the server's default database without opening it twice.
  • Refresh the row when a tab changes databases, its catalog arrives, or a database closes and reopens. Ignore late replies after the tab changes or the connection closes.

Test plan

  • Eight widget tests added for tab switches, background moves, sibling tabs, late and failed opens, disconnect/reopen, server-default databases, and stale catalog replies.
  • Extend the existing schema-based engine test to assert GTK selection. The original tab-selection test moves from sessions to other_databases and checks the actual selected row.
  • Local rustfmt and diff checks passed. Linux build, lint and tests run in CI; none ran locally under the build pause.

Screenshots

Query tabs in shop and analytics on a throwaway PostgreSQL server.

State Light Dark
Before Before, light Before, dark
After: analytics tab After, light After, dark
After: shop tab Shop tab, light Shop tab, dark

@datlechin
datlechin added this pull request to the merge queue Nov 9, 2026
@datlechin
datlechin merged commit 6dde185 into TableProApp:main Nov 9, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants