Skip to content

feat(linux-grid): add row numbers, row height and NULL text preferences - #4134

Merged
datlechin merged 12 commits into
TableProApp:mainfrom
sedax90:feat/linux-grid-display-settings
Nov 9, 2026
Merged

datlechin merged 12 commits into
TableProApp:mainfrom
sedax90:feat/linux-grid-display-settings

Conversation

@sedax90

@sedax90 sedax90 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add Data Grid preferences for row numbers, row height and NULL text. Changes reach every open grid and Preferences window.
  • Keep custom NULL text consistent in editable cells, results, row details and automatic column widths. Preserve active drafts, selection and manual widths.
  • Share one settings model across grids for the preferences added by this stack.

Test plan

  • Add GTK tests for two grids and two preference windows, isolated settings, row height, column widths, drafts and hidden row numbers after Reset Column Layout.
  • Add seven platform tests for defaults, live snapshots, separate backends, bounds and handler cleanup.
  • Update layout tests for the new Data Grid page: preferences_dialog_template_builds, general_page_contains_startup_and_history_groups, the_page_binds_its_history_group, and a_build_without_the_secret_shows_no_privacy_switch.
  • Correct row_height_preferences_change_the_allocated_row_height to compare allocated heights and load the app stylesheet in isolated grid tests. Compact, Standard and Spacious must produce increasing heights.
  • Run settings tests in separate GLib contexts and cover notifications while another thread owns the global context. Existing assertions stay unchanged.
  • Rust formatting and staged writing checks pass. Linux build and runtime test results are pending in CI.

Screenshots

Contributor's original Data Browser group, before this stack.

Light Dark
Before
After, preferences After, light After, dark
After, grid Grid, light Grid, dark

Spacious rows and (not set) for NULL values, using a throwaway SQLite database.

@datlechin
datlechin added this pull request to the merge queue Nov 9, 2026
…ay-settings

# Conflicts:
#	linux/crates/app/src/ui/data_grid/row_detail/fields.rs
#	linux/crates/app/src/ui/data_grid/row_detail/tests.rs
#	linux/crates/app/src/ui/data_grid/stripes.rs
#	linux/crates/app/src/ui/data_grid/test_grid.rs
#	linux/crates/platform/tests/settings.rs
@datlechin
datlechin merged commit dd75636 into TableProApp:main Nov 9, 2026
29 checks passed
datlechin added a commit to sedax90/TablePro that referenced this pull request Nov 9, 2026
TableProApp#4113 and TableProApp#4134 landed one after the other, and main stopped compiling at this call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants