Repository navigation
feat(linux-grid): set a value in every selected row - #4136
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Added 17 regression tests for 60-row undo/redo, mixed draft and saved rows, deleted and unkeyed rows, save locks, read-only access, invalid values, DEFAULT eligibility, selection scope and menu availability, unchanged values, history retention, column changes and the expression allowlist.
Existing tracker tests now call the public apply route after the internal recording methods changed; their expected behavior stays the same.
cargo fmt --all --check,git diff --checkand the staged writing check pass. Fast checks pass at7fc5ffd43: Clippy, 8 Meson test suites and 7 Secret Service tests. Flatpak and app/session integration tests also pass.Built the pushed head and checked Set to NULL on six selected rows, one-step Undo and Redo. Inspected captures in light and dark themes.
Screenshots
Set to NULL on the City column with all rows selected. Each After shot shows six unsaved changes.