Skip to content

feat(linux-grid): set a value in every selected row - #4136

Merged
datlechin merged 6 commits into
TableProApp:mainfrom
sedax90:feat/linux-set-value-rows
Nov 9, 2026
Merged

datlechin merged 6 commits into
TableProApp:mainfrom
sedax90:feat/linux-set-value-rows

Conversation

@sedax90

@sedax90 sedax90 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Set to Empty, NULL, DEFAULT or an expression changes the focused column in every selected row, with one Undo or Redo for the whole command.
  • Keep changes undoable when the selection exceeds 50 rows. Skip locked or invalid cells and report how many stayed unchanged.
  • Preserve draft rows, earlier undo steps and column identity when columns move.

Test plan

  • Added 17 regression tests for 60-row undo/redo, mixed draft and saved rows, deleted and unkeyed rows, save locks, read-only access, invalid values, DEFAULT eligibility, selection scope and menu availability, unchanged values, history retention, column changes and the expression allowlist.

  • Existing tracker tests now call the public apply route after the internal recording methods changed; their expected behavior stays the same.

  • cargo fmt --all --check, git diff --check and the staged writing check pass. Fast checks pass at 7fc5ffd43: Clippy, 8 Meson test suites and 7 Secret Service tests. Flatpak and app/session integration tests also pass.

  • Built the pushed head and checked Set to NULL on six selected rows, one-step Undo and Redo. Inspected captures in light and dark themes.

Screenshots

Set to NULL on the City column with all rows selected. Each After shot shows six unsaved changes.

Light Dark
Before Before, light Before, dark
After After, light After, dark

@datlechin
datlechin added this pull request to the merge queue Nov 9, 2026
@datlechin
datlechin merged commit 71757fe into TableProApp:main Nov 9, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants