Skip to content

feat(linux-menus): separate app and session menus - #4139

Merged
datlechin merged 10 commits into
TableProApp:mainfrom
sedax90:fix/linux-app-menus
Nov 9, 2026
Merged

datlechin merged 10 commits into
TableProApp:mainfrom
sedax90:fix/linux-app-menus

Conversation

@sedax90

@sedax90 sedax90 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Keep app and connection-library commands in Main Menu above the sidebar. Put database commands and Safe Mode in Session Menu beside the workspace.
  • Use GTK menu buttons and popovers. GNOME's menu guidance puts current-view commands in secondary menus. AdwApplicationWindow does not support GtkApplication:menubar, so this replaces the proposed menu bar.
  • Keep F10 for Main Menu, Ctrl+Q in Keyboard Shortcuts, and tab commands in tab menus.
  • At the narrow breakpoint New Query leaves the header, since the tab overview there has New Tab. The header with Refresh and Session Menu then fits the 360px floor.

Test plan

  • Widget tests cover command separation, accessible labels, Safe Mode and Disconnect through menu items, and the menu at 360px. The proposed menu-bar test is replaced to pin the supported design.
  • Rename two existing Safe Mode tests to name the action they exercise. Check menu access keys and absence of an application menu bar.
  • Local rustfmt and XML checks passed. Linux build, lint, tests and translations run in CI.

Screenshots

State Light Dark
Before: app and session commands share Main Menu Before, light Before, dark
After: Main Menu After, light After, dark
After: Session Menu Session Menu, light Session Menu, dark

Built the pushed head and origin/main in the Linux dev container. Opened each menu and checked every capture in light and dark modes.

@datlechin datlechin changed the title feat(linux): expose the application's menus as a GTK 4 menu bar feat(linux-menus): separate app and session menus Nov 8, 2026
@datlechin
datlechin added this pull request to the merge queue Nov 9, 2026
@datlechin
datlechin merged commit 841d3a4 into TableProApp:main Nov 9, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants