Repository navigation
fix(linux): open context menus beside the pointer so a long one slides instead of shrinking - #4149
Merged
Merged
Conversation
…s instead of shrinking
…u-size # Conflicts: # linux/crates/app/src/ui/workspace/sidebar/favorites_pane.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui/context_menu.rsbuilds and opens every pointer menu the same way: no arrow, on the trailing side (left in a right-to-left locale), top aligned. The menu's corner sits at the pointer; near the bottom it slides up, near the right edge it flips left.GtkMenuButtonpopovers are unchanged: a menu button's popover opens from its button.Test plan
context_menu::tests: side per text direction; a built menu has no arrow, opens to a side, top aligned; a row or cell is clipped to the part in view.a_rows_menu_opens_beside_the_pointer_so_a_long_one_slides_instead_of_shrinking(sidebar) anda_favorites_menu_opens_beside_the_pointer_like_every_sidebar_menu: a secondary press opens the menu to a side of the pressed point, with no arrow.the_keyboard_menu_of_a_cell_wider_than_the_grid_opens_beside_its_part_in_view: Shift+F10 on a cell three times the grid's width points inside the grid.