Skip to content

fix(linux): open context menus beside the pointer so a long one slides instead of shrinking - #4149

Merged
datlechin merged 9 commits into
TableProApp:mainfrom
sedax90:fix/linux-sidebar-menu-size
Nov 10, 2026
Merged

datlechin merged 9 commits into
TableProApp:mainfrom
sedax90:fix/linux-sidebar-menu-size

Conversation

@sedax90

@sedax90 sedax90 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Right-click menus opened below the pointer. GTK slides a popover along the screen edge only when it opens to a side, so a long menu (a table's in the sidebar) at a row mid-screen shrank to a scrollbar.
  • New ui/context_menu.rs builds and opens every pointer menu the same way: no arrow, on the trailing side (left in a right-to-left locale), top aligned. The menu's corner sits at the pointer; near the bottom it slides up, near the right edge it flips left.
  • Used by the sidebar tree and search results, the favorites folder tree, the data grid, the welcome list, query history and the diagram.
  • Menu key and Shift+F10 open the menu beside the focused row or cell, pointed at the part of it in view, so a cell wider than the grid does not push the menu off the window.
  • GtkMenuButton popovers are unchanged: a menu button's popover opens from its button.

Test plan

  • context_menu::tests: side per text direction; a built menu has no arrow, opens to a side, top aligned; a row or cell is clipped to the part in view.
  • a_rows_menu_opens_beside_the_pointer_so_a_long_one_slides_instead_of_shrinking (sidebar) and a_favorites_menu_opens_beside_the_pointer_like_every_sidebar_menu: a secondary press opens the menu to a side of the pressed point, with no arrow.
  • the_keyboard_menu_of_a_cell_wider_than_the_grid_opens_beside_its_part_in_view: Shift+F10 on a cell three times the grid's width points inside the grid.
  • Screenshots need a Linux build.

@datlechin datlechin changed the title fix(linux-sidebar): open a row's menu beside it so a long menu is not cut fix(linux): open context menus beside the pointer so a long one slides instead of shrinking Nov 9, 2026
@datlechin
datlechin merged commit 408df1e into TableProApp:main Nov 10, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants