Skip to content

fix(linux): keep screenshots in the Flatpak catalogue and state the license terms in the metainfo - #4152

Merged
datlechin merged 6 commits into
mainfrom
docs/linux-flathub-prep
Nov 9, 2026
Merged

datlechin merged 6 commits into
mainfrom
docs/linux-flathub-prep

Conversation

@datlechin

@datlechin datlechin commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Metainfo description: a paragraph says TablePro works fully without an account or a license, what a license covers, and when the app asks you to buy one (Flathub Requirements, Monetisation policy). Vietnamese in po/vi.po.
  • Metainfo: the comment above <content_rating> says usage data goes out unless turned off (ADR 0039), and the copyright header from Flathub's MetaInfo guidelines, Header.
  • Screenshots: a release tarball's metainfo names its own commit in the screenshot URLs. git archive writes it into build-aux/source-commit (export-subst). A release is built before its tag exists (ADR 0043), so the tag's URLs returned 404 and appstreamcli compose dropped every screenshot: the beta.3 catalogue on flatpak.tablepro.app has none. A git checkout keeps the tag URL.
  • build.rs fills @screenshots-ref@ for a plain cargo build the way Meson does, through metainfo_release::screenshots_ref.
  • Updated test: embedded_metainfo_pins_project_links_to_the_release_tag expects the commit from build-aux/source-commit in a release tarball's screenshot URLs, and the tag in a git checkout.
  • flatpak-test-site.sh fails when an app commit's catalogue lists fewer screenshots than its metainfo.
  • linux/README.md Screenshots, and docs/releasing.md "A future Flathub submission" lists the app-side checks a maintainer does before submitting.
  • lint-exceptions.json stays: the current linter reports neither entry, but CI's flatpak-github-actions:gnome-51 image (linter 27ae7df, 2026-09-22) still does.

Test plan

  • ghcr.io/flathub/flatpak-builder-lint@sha256:c8fd0f72802220332a1d6ec466a05232d0956f60ea03b9941561c6af0b79a3ac (d7d3f57): manifest on both manifests reports nothing; appstream on the release metainfo passes.
  • repo on beta.3 from the beta repository: appstream-missing-screenshots and appstream-screenshots-not-mirrored-in-ostree. On that commit with a catalogue composed from this branch's archive: only appstream-screenshots-not-mirrored-in-ostree and appstream-external-screenshot-url, which Flathub's build resolves by mirroring.
  • git archive of this commit writes its hash into source-commit; Meson on the archive names it in all 4 URLs; appstreamcli compose keeps all 4 with no tag.
  • The new check fails on the published beta.3 commit (0 of 4) and passes on the recomposed one.
  • appstreamcli validate, check_packaging.py, the packaging unit tests, po/check-complete.sh (vi complete) and msgfmt --check.

@datlechin
datlechin enabled auto-merge November 8, 2026 20:51
auto-merge was automatically disabled November 9, 2026 10:53

Merge commits are not allowed on this repository

@datlechin
datlechin merged commit 5582b50 into main Nov 9, 2026
79 of 82 checks passed
@datlechin
datlechin deleted the docs/linux-flathub-prep branch November 9, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant