Repository navigation
fix(linux): keep screenshots in the Flatpak catalogue and state the license terms in the metainfo - #4152
Merged
Conversation
…icense terms in the metainfo
datlechin
enabled auto-merge
November 8, 2026 20:51
auto-merge was automatically disabled
November 9, 2026 10:53
Merge commits are not allowed on this repository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
po/vi.po.<content_rating>says usage data goes out unless turned off (ADR 0039), and the copyright header from Flathub's MetaInfo guidelines, Header.git archivewrites it intobuild-aux/source-commit(export-subst). A release is built before its tag exists (ADR 0043), so the tag's URLs returned 404 andappstreamcli composedropped every screenshot: the beta.3 catalogue on flatpak.tablepro.app has none. A git checkout keeps the tag URL.build.rsfills@screenshots-ref@for a plain cargo build the way Meson does, throughmetainfo_release::screenshots_ref.embedded_metainfo_pins_project_links_to_the_release_tagexpects the commit frombuild-aux/source-commitin a release tarball's screenshot URLs, and the tag in a git checkout.flatpak-test-site.shfails when an app commit's catalogue lists fewer screenshots than its metainfo.linux/README.mdScreenshots, anddocs/releasing.md"A future Flathub submission" lists the app-side checks a maintainer does before submitting.lint-exceptions.jsonstays: the current linter reports neither entry, but CI'sflatpak-github-actions:gnome-51image (linter 27ae7df, 2026-09-22) still does.Test plan
ghcr.io/flathub/flatpak-builder-lint@sha256:c8fd0f72802220332a1d6ec466a05232d0956f60ea03b9941561c6af0b79a3ac(d7d3f57):manifeston both manifests reports nothing;appstreamon the release metainfo passes.repoon beta.3 from the beta repository:appstream-missing-screenshotsandappstream-screenshots-not-mirrored-in-ostree. On that commit with a catalogue composed from this branch's archive: onlyappstream-screenshots-not-mirrored-in-ostreeandappstream-external-screenshot-url, which Flathub's build resolves by mirroring.git archiveof this commit writes its hash intosource-commit; Meson on the archive names it in all 4 URLs;appstreamcli composekeeps all 4 with no tag.appstreamcli validate,check_packaging.py, the packaging unit tests,po/check-complete.sh(vi complete) andmsgfmt --check.