Repository navigation
ci(release): tag with one script, forward-port at merge and hold CI while a tag starts - #4163
Merged
Merged
Conversation
…hile a tag starts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apple/scripts/release/tag.sh <tag> <commit>runsapple/RELEASING.md, Tagging: waits for the line's CI push run on the commit (gh run list --commit,gh run watch --exit-status),git tag -s,version.py check,git push origin <tag>(a failed check runsgit tag -d), then finds and watches the tag's Release run. A run that has not appeared yet is looked up again every 10 s for a minute.main(and a newer open line) once the release PR merges and the tag's App and Plugins jobs start, not after publishing. The docs changelog PR still waits for publishing.mainand the newer line through its forward-port.Test plan
test_tag.pyrunstag.shin a throwaway repository with a bare origin and stubgh,gpg,sleepandversion.py: a green run and check push a signed tag and watch its Release run; a red CI run tags nothing; a failed check deletes the local tag and pushes nothing; a missing CI run is looked up six times, then refused; a missing argument prints the usage.shellcheck --severity=styleandcheck-lib-sourcing.pypass; the release tooling tests pass locally.