Repository navigation
fix(ios): stop capped reads downloading the rest, apply query timeouts and refuse unreadable SSH host keys - #4179
Merged
Merged
Conversation
…s and refuse unreadable SSH host keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes from the 2026-11-10 code audit (wave 3) for the iOS app, plus the SSH host key fix in the macOS app.
Row cap (IO-04)
CALL,... RETURNINGand every write read to their end.Long text (IO-06, partly)
Query timeout (IO-07)
statement_timeout, Oracle uses the shared core's deadline, SQL Server setsLOCK_TIMEOUT(the Mac's mapping, which bounds lock waits only).Memory trim (IO-08)
SSH host keys (IO-11, macOS and iOS)
KnownHostsFilein TableProSSHTransport, for both apps. Lines it cannot parse are kept on write; a host named only by such a line is refused.Not done here
Test plan
verify.sh: macOS build,HostKeyStoreTests,KnownHostsFileTests, 24 iOS suites (185 tests) and the driver suites again after review (55 tests), lint, both catalogs.MySQLRowCapTests(row-streaming fake server: kill at the cap,DELETE ... RETURNINGandCALLread to the end),MSSQLRowCapTests,LazyCellKeyTests(DuckDB end to end),NativeDriverQueryTimeoutTests(PostgreSQL fake server),KnownHostsFileTests, and cases inHostKeyStoreTests(both apps),HostKeyVerifierTestsandDataBrowserViewModelTests.