Repository navigation
perf(macos): move result, grid and editor work off the main actor, stream exports and imports, and cap pool and driver reads - #4181
Merged
Conversation
…ream exports and imports, and cap pool and driver reads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance fixes from the 2026-11-10 code audit (wave 3, Phase 4) for the macOS app. Results stay the same; the work moves off the main actor, becomes incremental, streams, or is capped.
Grid
Results
TableRows.preparing); a mask or Reveal change in between rebuilds on the main actor as before. Stop ends the build within 4,096 rows.Drivers and pool
PluginStreamHeader.rowLimit, additive), and export warns as for other drivers.fetchForeignKeys(forTables:)reads only the tables asked for unless the driver has a bulk query.Import and export
Editor and sync
Behavior changes to know
Tests changed on purpose
trimClosesOnlyIdleConnectionsreplaced bywaitingLeaseTakesOnlyAnIdlePlace(the cap is now hard).unreadableElementFollowsTheErrorModereplaced byunreadableElementFailsTheImport(errorHandling:).beginSheet,addRows,finishSheet,continueSheetnow throw; their callers and tests gainedtry.PluginKit
PluginStreamHeader.rowLimitand new default bodies. Kit stays 43 (unreleased), minimum 19; the ABI check passes against v0.86.0-beta.1.Not done here
CellDisplayFormatteris main-actor only.rowLimitat 5,000,000; Object Copy and Data Compare can still copy a HANA table short without saying so.Test plan
verify.sh: build, AllPlugins, the PluginKit ABI check, the Unit plan,TableProCoreandTableProOraclepackage tests, an iOS build withDataBrowserViewModelTests, lint and the catalog check.TableRowsPreparedRowsTests,ResultRowsBuildOffMainTests,ResultSetMenuModelTests,UndoStepRepaintTests,ForeignKeysForTablesReadTests,PluginDriverDefaultCancellationTests,PluginDefaultStreamRowLimitTests,ExportDriverRowCutTests,LibPQCappedCursorReadTests,OracleRowBatcherTests,EtcdRangeScanTests,SyncConnectionPullBatchTests, plus cases inGridFindEngineTests,RowVisualIndexTests,TabSessionRegistryTests,DataGridValueFilterTests,MetadataConnectionPoolCapacityTests, the XLSX and JSON tests. Each pins work done (cells read, rows built off main, reads issued, bytes held), never time.SELECT bump(g), nextval('s')all kept, a refused DECLARE runs nothing, a cancel during MOVE ends the tail.LibPQStopBeforeStatementTestschecks what reaches a loopback server on Stop. etcd was not run against a live server.