Repository navigation
fix(macos): keep T-SQL blocks and rewinds whole, stop CSV sanitizing by default, and fix Stop, defaults and gate cancels across drivers - #4185
Merged
Conversation
…by default, and fix Stop, defaults and gate cancels across drivers
datlechin
enabled auto-merge (squash)
November 11, 2026 07:53
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Low-severity fixes from the 2026-11-10 code audit (wave 4, Phase 9) for the macOS app, five defects found in wave 3, and the CSV sanitize default in the shared core and the Linux app.
Editor
F_SETNOSIGPIPEand the throwingwrite(contentsOf:).IF,WHILE, bareBEGIN ... ENDandBEGIN TRY ... END CATCHstay one statement for Run Current, the gutter and the band.BEGINopens a block only where one can stand, soCREATE TABLE begin(...); DROP TABLE usersstill splits.IF c stmt; ELSE stmt;still splits at the;.QueryClassifier.isMultiStatementrefuses a block holding more than one statement (any;outside parentheses not followed by the block'sEND,ELSEor;). A block holding one statement, such asIF x BEGIN SELECT 1; END, now counts as one statement for callers without multi-statement leave (explain_query,export_data, the execution gate), where main counted it as two; inner statements are still tiered. Paired docs: docs: CSV formula sanitizing is off by default, and a one-statement T-SQL block counts as one statement docs#195, which also flips the CSV default.;inside a PostgreSQLCREATE RULE ... DO (action list no longer ends the statement; elsewhere a;ends it as before, so a stray(cannot swallow the rest of a script.NSRangeExceptionwhen the caret is outside the visible range:findClosingPairclamps to the text and the search window follows the caret.Edits and tabs
DEFAULTkeyword with the expression flag, never text. Engines whose plugin writes its own rows still receive the legacy__DEFAULT__text, so the literal text is refused there on save and on restore, naming the column; the JSON view and Copy as JSON show a pending default asnull.Import and export
CsvOptions::default(), Linux GSettingscsv-sanitize-formulas, the macOS option), as RFC 4180 writes a field as stored; the quote stays in the data for any importer. When on, the export says how many values got a quote. Users who saved any CSV option keep their stored value. The MCPexport_dataCSV and the query history CSV export keep sanitizing.PluginColumnNumbers, now shared with the XLSX writer), so1.10in a text column is left alone andNullable(Float64),money,BINARY_DOUBLE,BIGNUMERICget it.decode('…','hex'), Redshift asfrom_hex('…'), KingbaseES as before; Copy as SQL writes DuckDB and Oracle binary in their own forms, and an empty Oracle BLOB is no longer NULL.[or{is JSON only when it parses as JSON; bracketed and case-only header matches find their columns.Drivers
UPDATE ... IF EXISTS;[applied] = falsefails the save.SETwith NX or XX showsOKor(nil).stateLock, whichdisconnect()takes; Stop uses the thread id saved at connect.00123) as a string.Structure
PARTITION ID '<id>'fromsystem.parts.partition_id, validated as the server validates it.GatedOperationFailure.PluginKit
PluginColumnNumbers,PluginRowWriters.isFormulaLike(_:), a changed default binder body. Kit 44, since v0.87.0-beta.1 shipped 43; minimum 19. The ABI check passes.Known limits
__DEFAULT__, including drivers that never read it, until PluginKit carries the default mark.PARTITION ID, Cassandra LWT, KingbaseES and Redshift binary literals.Tests changed on purpose
CompareSQLLiteralTests,SQLRowToStatementConverterTestsandDataSyncScriptBuilderColumnTests; the sanitize default inFormatLimits.csv.__DEFAULT__text marker (listed inb-editsreport); five Vim line-count tests replaced by one recount test.encoding_sink.rs, threeexport_ledger/tests.rstests andcsv_options_round_trippinned the old sanitize default.Test plan
verify.sh: build, AllPlugins, the PluginKit ABI check, lint, the Unit plan (29920 of 29922 before the last two fixes, then the five affected suites),TableProCore(5023), an iOS build withDataBrowserViewModelTestsandQueryCompletionCatalogTests(75),core tablepro-core, the catalog check.TSQLControlFlowBlockTests,QueryClassifierTSQLBlockTests,SQLParenthesizedSemicolonTests,LSPTransportBrokenPipeTests,StatementCaretTableTests,TriggerEditorFontSizeTests,TableLoadAfterSafeModePromptTests,WindowCloseSaveEveryConnectionTests,PayloadRowPlannerHeaderMatchTests,RowPayloadFormatTests,FormatSettingsChangedMidRunTests,StartupCommandWarningTests,TeradataStopTests,SchemaWriteGateDenialTests,PrincipalApplyGateDenialTests,TriggerGateDenialTests, plus cases inTextViewControllerTests,RewindPlannerTests,ClickHousePartStatementsTestsand the CSV and compare tests.