Repository navigation
fix(plugins): bind parameters by type, carry the default mark, stream large reads, and read Oracle region zones - #4190
Merged
Merged
Conversation
…by default, and fix Stop, defaults and gate cancels across drivers
… large reads, and read Oracle region zones
# Conflicts: # apple/Packages/TableProCore/Sources/TableProTeradataCore/TeradataConnection.swift # apple/Packages/TableProCore/Tests/TableProTeradataCoreTests/TeradataStopTests.swift # apple/Plugins/CassandraDriverPlugin/CassandraRowWriter.swift # apple/TablePro/Core/DataWrite/RowChangeStatementFactory.swift # apple/TableProTests/Core/DataWrite/RowChangeStatementFactoryExpressionTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
42as a number and quotes anything else,1E5included. PluginKit carries the types inPluginStatementContext.parameterKinds; Fetch All and pagination bind the same types.PluginRowChange.defaultColumns,PluginCapabilities.columnDefaultMarks), so the text__DEFAULT__is saved as text on the Mac and in the iOS app._idfrom the server.chunked=true.PluginBoundedStream.collectmarks a result cut at the limit its stream declared.PluginStopRolledBackTransaction).SYS.V_$TIMEZONE_NAMESread once per connection. Without access, or for a name macOS does not know, it shows the UTC instant with+00:00. Write-back takes a region name.ONLYon a partitioned parent reads none. SQL export, Object Copy and a row-scoped export build that read in host code, so INHERITS in the DDL would restore every child row twice.OracleCellFormattingTests.testRegionNamedZoneIsAPlaceholder(nowtestRegionZoneIsTheWallClockAndOraclesName),TeradataStopTests.stopAbortsTheRequestAndKeepsTheSession(ANSI, expects the rollback),QdrantRowWriteTests.duplicatedRowGetsNewID,ClickHouseDMLStatementTests.insertStaysPlainandemptyInsertTakesDefaults(pass the mark),SQLParameterExtractorTests,PaginationStateTestsandMainContentCoordinatorSortTests(typed values).Needs the maintainer
V_$TIMEZONE_NAMESsees region values as UTC with+00:00rather than a placeholder.Known limits
__DEFAULT__: their writers cannot throw. Typesense and Firebase refuse a duplicated row's defaulted id.BTrolls back silently. Scripts, Fetch All and exports end as a plain cancel.CANCEL SESSIONonce a cursor is open; a Stop there waits for the fetch, then severs after 30 s.apple/scripts/probes/check-oracle-time-zone-regions.sh); each driver's default mark.Test plan
verify.sh: build, AllPlugins, the ABI check, lint, the Unit suites for the changed types,TableProCore(PluginKit, Teradata, InfluxDB, Qdrant, Spanner, Memcached),TableProOracle, the HANA helper'sgo vetandgo test.PluginTypedParameterBindingTests,PluginBoundedStreamDeclaredLimitTests,PluginDriverAdapterParameterKindTests,StopRollbackNoticeTests,RedisColumnDefaultTests,TeradataStreamTests,InfluxGridStreamTests,OracleTimeZoneRegionsTests, the HANA cursor tests in Go, and cases inRowChangeStatementFactoryExpressionTests,MemcachedKeyListingTestsand iOSPluginBackedDriverTests.