Skip to content

fix(macos): keep value colors readable on every row and fix masking and sort for boolean columns - #4207

Merged
datlechin merged 4 commits into
mainfrom
fix/grid-type-colors-followup
Nov 11, 2026
Merged

datlechin merged 4 commits into
mainfrom
fix/grid-type-colors-followup

Conversation

@datlechin

@datlechin datlechin commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Summary

Follow-up to #4205 from a full re-review.

  • Bundled themes: the nine value colors reach 4.5:1 on the background, the alternate row, and the modified and inserted washes over both; no two match in a theme. Nord and Dracula modified washes drop from 30% to 15%, like the other themes.
  • The Values contrast note checks the same surfaces.
  • Masking: a type rule like tinyint or bit matches TINYINT(1) and BIT(8) again, but only after no rule matched as written, so a later column rule keeps winning.
  • Sorting a boolean column holding integers or true and false orders them as numbers; highlight rules compare them as numbers.
  • CellDisplayFormatter.format no longer runs the JSON and PHP checks; only the grid's cache fill does, so Find and the value filter cost what they did before feat(macos): color grid values by type from the theme's Values colors #4205.
  • String color covers keyword, wildcard, constant_keyword, ascii, long and sysname.
  • Tests: the Color values by type setting from change to grid, sync of its category, the grids that opt in and those that do not, foreign key cells, the masking and sort cases. Required arguments replace two defaults only tests used.
  • Tests updated on purpose: ThemeContrastTests (every row surface), paletteWithoutValueColorsDrawsText removed with its fallback, settingChangeRecolorsWithoutReload goes through the setting, AppSettingsCategoryParityTests asserts behavior, MySQL BIT(8) fixtures in CompareSQLLiteralTests and TableTransferServiceTests.

Test plan

  • Unit plan and TableProThemeTests pass. New tests cover each regression case above.

…followup

# Conflicts:
#	apple/TablePro/Core/Services/Formatting/CellDisplayFormatter.swift
@datlechin
datlechin merged commit 3bebd1a into main Nov 11, 2026
9 of 10 checks passed
@datlechin
datlechin deleted the fix/grid-type-colors-followup branch November 11, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant