Repository navigation
fix(macos): keep value colors readable on every row and fix masking and sort for boolean columns - #4207
Merged
Conversation
…nd sort for boolean columns
…followup # Conflicts: # apple/TablePro/Core/Services/Formatting/CellDisplayFormatter.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #4205 from a full re-review.
tinyintorbitmatchesTINYINT(1)andBIT(8)again, but only after no rule matched as written, so a later column rule keeps winning.CellDisplayFormatter.formatno longer runs the JSON and PHP checks; only the grid's cache fill does, so Find and the value filter cost what they did before feat(macos): color grid values by type from the theme's Values colors #4205.keyword,wildcard,constant_keyword,ascii,longandsysname.ThemeContrastTests(every row surface),paletteWithoutValueColorsDrawsTextremoved with its fallback,settingChangeRecolorsWithoutReloadgoes through the setting,AppSettingsCategoryParityTestsasserts behavior, MySQLBIT(8)fixtures inCompareSQLLiteralTestsandTableTransferServiceTests.Test plan
TableProThemeTestspass. New tests cover each regression case above.