Repository navigation
fix(linux-mongodb): keep NULL apart from a missing field, export number fields as numbers, write mongosh constructors - #4208
Merged
Conversation
…er fields as numbers and write mongosh constructors
…#4201 in the MongoDB tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #4202, from a full review of it.
$$REMOVE, so an untouched new-row cell is left out; NULL typed in the grid writesnull(validators that require a nullable field pass); Set to Default on a saved row is$unset. A NULL the app read (Duplicate Rows, a paste, a CSV import's null marker) is left out, since a page reads a missing field as NULL (SqlDialect::reads_missing_as_null,edit::read_cell).document::NUMBER_TYPE: row exports (CSV, TSV, XLSX, JSON, HTML, XML, Markdown, text) write its values as numbers, doubles as doubles and other fractions exactly; other engines' JSON columns are unchanged. Its filter offers comparisons only.NumberLong,NumberDecimal,Double,ISODate,ObjectId,UUID,BinData,Timestamp,BSONRegExp,MinKey,MaxKey), which TablePro's parser and the driver read back to the same BSON.$projectof the census fields (a field added mid-export no longer fails it), and columns keep the tab's order.$mergeinto the collection being aggregated.mongodb.md,adding-drivers.md,testing.md(public DNS and port 27017 for the seed-list tests)._idasValue::Intnow expectValue::Int32, which fix(core): bound result bytes, keep MongoDB number types, hold FFI secrets in secrecy, keep long iOS query values whole and give each iOS connection one session owner #4201 made the cell type (seed_list,replica_set,stop,export,session_mongodb); they fail on main.field_types(int and long isnumber),a_field_of_ints_and_doubles_keeps_the_comparisons(noContains),shell_literalcases (Double(2),BSONRegExp),document::testsNULL cases ($set: null, Default is$unset),export/sql.rsback to its pre-fix(linux-mongodb): seed-list login, field-safe writes and exports, UUID columns, drops that ask, stops on Atlas free tier #4202 tests.Test plan
tls::forwarded::*failures happen on main too on macOS.row_edits.rs,paste.rs,tracked_values.rs,data_grid/mod.rs) does not build on macOS: CI's Linux jobs.Refs #3646