Repository navigation
feat(windows): filter tables, show structure and definitions, export results and keep query history - #4213
Merged
Conversation
…results and keep query history
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit item WN-09, as the macOS app does it, over reads the core already does for the Linux app.
read_pageon the session's pooled connections and arrives as the usual run events, so a table tab no longer holds an editor connection.table_queryis gone.QueryEditor::use_database). Tree menu: Open, Show structure, Show DDL, Copy name.filter.*,browse.*). Bindings regenerated.windows/AGENTS.mdupdated.Not in this PR: SQL completion. The caret analysis lives in the Linux app and has to move into the core first, then the editor needs its popup.
Test plan
tablepro-ffi, 171 pass locally):tests/browse.rs(filtered pages bind and count, unknown column, two-statement raw SQL and a bad value refused before any read, cancel, structure and the view's missing DDL, trigger definition,use_database),tests/export.rs(CSV, JSON, SQL INSERT, whole table with a filter, cancel and failure leave no file, unfinished rows refused),tests/history.rs(record, search, withheld statements, delete, clear). These fail on main, where the API does not exist.TablePro.Interop.TestsBrowseTests, ExportTests, HistoryTests on real SQLite files;TablePro.App.Model.Testsfilter, structure, definition tab, history list and recording, session tabs, export plan, database move;TablePro.DataGrid.Model.TestsTextGridDataTests.TablePro.Appcompiles on CI's Windows runners only (Native AOT publish passes). UI testsTableBrowseTests(filter, structure, DDL; shots 50 to 52) andBrowseObjectsTests(trigger definition and Open in editor, Export dialog, history and open again; shots 53 to 55). The system Save As dialog is not driven by UI Automation; the core's and the interop's export tests write the files.Screenshots
Before, a table tab had only its rows:
After, a filter on Track:
Structure, Indexes:
A trigger's definition:
The query history:
Needs the maintainer