Repository navigation
fix(plugins): keep NoSQL edits on the record, key and TTL they read, page Kafka by records and bound Redis string reads - #4220
Merged
Conversation
…page Kafka by records and bound Redis string reads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit 2026-11-12, lane nosql-drivers (NQ-1 to NQ-10).
USING TTLwith what is left (0for a cell that never expires when the table has a default), cells with different TTLs go in one conditional batch, undo delete puts the TTLs back, and an edit of a cell that expired since the read is refused (NQ-2)."_id": 1, as the shared core's pager does, so equal values keep one order across pages (NQ-4).GETRANGEup to 64 KiB and marks a longer one. A Value edit of it, or a new row copied from a preview, is refused. Export, includingKEYS, reads whole values; consoleKEYSandSCANsummarize in batches (NQ-6)._index,_idand_routing, and updates, deletes and the read before an update use them, so routed and child documents save on their shard (NQ-7).gets, a Flags-only or Value-only edit is acas, and EXISTS or NOT_FOUND fails the save (NQ-10).Tests changed on purpose:
MongoDBOnIOSTests.pageQueryCombinesFiltersAndSearchexpects the_idtiebreak.RedisKeyMetadataReadTestspass the newstringByteLimit:argument.Needs the maintainer:
_id, which a single-field index cannot serve, so a large collection sorts in memory. MongoDB's Sort Consistency guidance and the core's pager do the same.Docs: TableProApp/docs#211 (draft).
Test plan
swift testin TableProCore for TableProRedisCoreTests, TableProCassandraCoreTests, TableProKafkaCoreTests, TableProBigtableCoreTests and TableProMemcachedCoreTests: 371 passed. New: TTL grouping and batch text, Kafka tail walk and next offset past markers, exact UTF-8 decode, Redis string preview, Bigtable locator keys, Memcachedcaschoice.verify.sh pluginsbuilds every registry plugin. MongoDB, SurrealDB, Elasticsearch, the Cassandra browse glue and the Kafka engine have no test target; their paths were traced by hand and reviewed in four rounds.MongoDBOnIOSTests) runs on CI only: this Mac has no iPhone simulator.