Repository navigation
perf(core): cut PostgreSQL and MySQL round trips, cap FFI workers, and fix slow Linux grid deletes and highlights - #4224
Merged
Merged
Conversation
…d fix slow Linux grid deletes and highlights
…ped savepoint cursor, keep MySQL describes uncached
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance audit 2026-11-11, Rust core and Linux items. Round trips are counted on the wire with a new test transport (
RoundTripCounter), against PostgreSQL 17 and MySQL 8.4 in Docker.tablepro_cursoropen, so the next SELECT failed with 42P03 and aborted the transaction. The cursor's savepoint is now rolled back, which closes it.Fastrecycling (its documented default,Client::is_closed()) plus the server check only for a connection idle past the keepalive idle time (30 s). Idle time is read on the wall clock as well, since deadpool'sInstantstops while the machine sleeps. A pooled read 2 -> 1 round trip. The cost: a connection a route drops while the machine is awake, within 30 s of its last use, fails one read and leaves the pool.SELECT 1leaves the pool, and a login of its own decides whether the route is lost, so one stale member no longer marks the whole connection lost. MySQL keeps its ping (sqlx has no local closed signal, so the ping is what finds a server-closed connection) and SQL Server keeps@@TRANCOUNT(it guards transaction state, not only liveness).tablepro_session::runtime::worker_count).Test plan
wire_round_tripsin the PostgreSQL and MySQL integration suites (fail on main with the counts above),a_stop_before_the_fetch_in_a_transaction_leaves_no_cursor_behind(42P03 on main),an_empty_page_shows_the_columns_after_a_type_change,the_runtime_keeps_the_worker_count_of_a_database_client(12 on main),deleting_the_largest_paste_takes_one_pass_and_its_undo_entry,a_row_works_out_its_highlight_once_for_all_of_its_cells,an_edit_to_the_rule_column_recolours_the_other_cells_of_its_row,a_tracker_change_no_row_was_redrawn_for_reaches_the_next_draw./procmemory peak, the local socket container, macOS TLS verifier wording).