Repository navigation
fix(macos): keep a running query tab on its database, keep what a Stop committed, save tabs of content-opened connections, scope sidebar commands to their window and keep editor undo per tab - #4225
Merged
Conversation
…nd editor undo on the right tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.schemaMoved), as rows from another database already were. A query tab's schema stays where the picker put it: showing a pinned result, or a run summary with no origin, no longer rewrites it. Pinned results read elsewhere offer no Fetch All, and Copy as UPDATE names the schema the rows came from.open_table_tab, Reopen Closed Tab) reads its saved tabs behind the founding one, keeps the founding tab's database, and saves again. A workspace rebuilt after a reconnect restores its tabs instead of reopening the founding content.SidebarViewModelTestsbatchToggleTruncateShowsDialog,batchToggleTruncateCancels,batchToggleTruncateNoSelection,batchToggleDeleteShowsDialog,batchToggleDeleteCancels,confirmTruncateMovesFromDeletes,confirmDropMovesFromTruncates,confirmOperationStoresOptions,SidebarViewModelCopyTests;confirmOperationResetsDialogStateremoved.Test plan
QueryContainerChangeTests,ResultEditabilityTests.schemaMoveRefuses,StoppedRunKeepsWorkTests,TabExecutionRegistryTests(stop cases),ContentFoundedRestoreTests,SidebarTableOperationWindowTests,SQLEditorTabHistoryTests,VimDocumentMarksTests,SourceEditorUndoHistoryTests,UndoHistoryTests.verify.sh build,teston the suites above and the suites that own the changed types,lint.Needs the maintainer