Repository navigation
fix(data-grid): keep edits through saves, undo and paste, hold keyed writes and restores to their rows - #4226
Merged
Merged
Conversation
…writes and restores to their rows
datlechin
enabled auto-merge (squash)
November 12, 2026 05:28
# Conflicts: # apple/TableProTests/Core/DataWrite/DataWriteExecutorTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes from the 2026-11-12 audit, lane edits (macOS grid edits, saves, structure save).
_id). A UUID key the server does not fill still gets a fresh UUID per row. A blank key that refuses NULL stays NULL, not an empty string.DataWriteExecutorTests.fewerRowsIsNotAFailure(now MySQL),RowOperationsManagerPasteTests(key is AUTO_INCREMENT),RowPasteForeignTextTests,RowOperationsFieldAbsenceTests.sqlPasteHasNoAbsence,RowOperationsManagerUUIDKeyTests.pasteWithoutUUIDKeysKeepsTheKey,RowOperationsExpressionClipboardTests(key is an identity),JSONViewerWindowCommitTests(callers now get the editor text).Needs the maintainer
CLIENT_FOUND_ROWS, which would also change the affected-row count every MySQL query reports.SET NOCOUNT OFFon keyed writes).Test plan
RowEditUndoStepTests,SaveInFlightEditGateTests,RowOperationsManagerPasteKeyTests,RowOperationsManagerDuplicateRowsTests; cases added toDataWriteExecutorTests,DataWriteExecutorLookupTests,RewindPlannerTests,StructureChangeRebaseTests,MultiRowEditStateJsonTests,JSONViewerWindowCommitTests,SQLStatementGeneratorBatchDeleteScaleTests,SQLStatementGeneratorImportTests.UPDATE t SET a = 1over two rows already holding 1.