Repository navigation
fix(macos): reuse one Vault database user per profile and wait for a new one to load - #4230
Merged
Merged
Conversation
…new one to load # Conflicts: # apple/TablePro/Core/Database/NativeDumpService.swift # apple/TablePro/Core/Plugins/PluginDriverAdapter.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VaultLeaseCacheowns each lease and hands out holds. A lease is revoked when the last live connection that used it disconnects, after 10 minutes unused, and at quit (up to 3 seconds for Vault). Before, quit left every lease alive until its TTL.loginStartLock. Measured withscripts/probes/check-freetds-login-messages.sh.tunneledConnectiondroppedcredentialMode, so it used the connection's own Keychain password.ConnectionFailureClassifier.isAuthenticationFailurereplacesDatabaseManager.isAuthenticationFailure, so the driver adapter can call it off the main actor.PluginDriverAdapter.cellValue(for:)moved unchanged toPluginDriverAdapter+CellValue.swiftto keep the adapter under SwiftLint's length limits.VaultDatabaseCredentialsTests"Each sign-in reads a new lease" is now "Sign-ins for one owner and role share one lease"; the revoke-on-release test now revokes throughendUse;VaultLeaseOwnershipTests"A driver revokes the lease it signed in with when it disconnects" now hands the lease back to the cache.Credential profile editor, Vault caption (light, then dark):
Docs: TableProApp/docs#221 (draft, merges after this one).
Test plan
VaultLeaseCacheTests: one read per key, concurrent sign-ins, idle retention, endings reach every hold, a refusal on a revoked, live, or accepted then refused lease,endUsewith live and leftover connections,end(), quit revoke, redial delays.VaultLeaseOwnershipTests: a young lease redials until accepted; the window closing givesVaultUserNotLoadedand keeps the user; a PostgreSQL refusal of a revoked lease replaces it; a 1045 after an accepted sign-in replaces it; a 1044 keeps it; a cancel during the wait dials no more.ConnectionFailureClassifierTests: refused logins per engine, SQL Server refusals that pass.VaultDatabaseCredentialsTests(429 and 503 as unreachable, 500 as Vault's failure),ReconnectCredentialRecoveryTests,DatabaseManagerTunnelTests(credential profile through a tunnel),PasswordSourceTestModelTests,PasswordSourceResolverTests,NativeDumpRegistryTests,PluginDriverAdapterConcurrencyTests.scripts/probes/check-freetds-login-messages.shagainst the shippedlibsybdb.a: OK.verify.sh plugins: PASS.Fixes #4189