Repository navigation
perf(macos): faster ER diagram layout and drag, inspector row changes and blob cells - #4231
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ERDiagramLayout.layOutis@concurrentand awaited insidelayoutTask, so Reset Layout, Compact Mode and Collapse Junctions cancel the run they replace. The unstructuredTask.detachedbefore never saw the cancel.editorID. Row step, 30 columns: 129.5 to 62.9 ms, 121 to 84 views built (hosted Debug probe).storedBytes. Per 4 MB cell:.bytesgrid 8.5 to 0.001 ms, Latin-1 text grid 35.5 to 0.44 ms, hex dump 15.1 to 0.09 ms. Output identical on 103k generated inputs.layoutChangedgoes out when the drag ends. Edges outside the redrawn rect are not stroked; routes are reused until the scene changes. 500 tables: 4.74 to 0.034 ms per drag event, 1200x800 redraw 23.5 to 10.9 ms (Debug).MultiRowEditStateExpansionTests.expansionSurvivesSelectionChangenow checkseditorID, sinceidno longer changes with the selection.Needs the maintainer
Test plan
ERDiagramLayoutTests(cancelled layout throws, positions recorded from the old layout),ERDiagramEdgeCullingTests,ERDiagramAccessibilityTests(column change, added table),MultiRowEditStateTests(field and editor identity),InspectorRowChangeTests(in place vs rebuilt editors),StringHexDumpTests(prefix reads).