Repository navigation
perf(windows): load restored table tabs when shown, read row estimates first, share the editor device, stop the idle caret and drop unused Windows App SDK parts - #4232
Merged
Conversation
…mate first, share the editor device, stop the idle caret and drop unused Windows App SDK components
…p an asked count and a fresh catalog, hide stale estimates
…out a removed device
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Loaded), not when the session restores it. A restored filter's bar and choices wait for that too. (WIN-01)table_row_estimateoverConnection::table_estimate(the Linux pager's path). As on macOS: an exact count the engine keeps is the total; under 100,000 rows, or with no estimate, the server counts as before; from 100,000 on nothing is counted, the status says "of about N rows" (no total under a filter), and Count rows in the command bar runs the count. Last page, Go to page and All rows still need an exact count. (WIN-02)Microsoft.WindowsAppSDK.WinUIinstead of the metapackage, as the Windows App SDK 1.8 notes allow, and the app prunes the metapackage the Community Toolkit 8.2 still names (PrunePackageReference). AI, ML (ONNX Runtime, DirectML), Search, Widgets and DWriteCore no longer ship. ADR 0005 updated. (WIN-04)UISettings.ColorValuesChanged, its blink timer'sTickand its window activation listener are held only while it is loaded, so a closed query tab's editor can be collected. (WIN-05)SPI_GETCARETTIMEOUT) with no input, shown, and is hidden with no timer while the window is inactive (InputActivationListener), as Win32 edit controls do. (WIN-07)Behavior notes
TabView::OnDragStartedin microsoft-ui-xaml), so the spare's workspace has to exist before a drag and cannot wait for the connection.Needs the maintainer
Test plan
TableTabCountTests,CaretBlinkTests,tests/TablePro.Editor.Tests(WinUI, Windows only: editor collected after Dispose, one device and one swap chain per show, the blink stops after the timeout), ShowAsync cases inTableTabTests, the filter order theory inObjectFoldersTests,RunResultsTestswith 10,000 sets,a_tables_estimate_is_unknown_until_analyze_writes_its_statistics(FFI),AnEstimateIsNoneUntilAnalyzeWritesTheTablesStatistics(Interop).release-windows.ymlruns 43164825446 (main) and 43169528630 (this branch), whose packages installed and started on Windows Server 2022 x64 and Windows 11 Arm64.