Repository navigation
perf(macos): ship smaller binaries: no exports, one lease chain, no duplicate helpers or unused clients - #4233
Merged
Merged
Conversation
…uplicate helpers or unused clients
# Conflicts: # apple/TablePro/Core/Database/DatabaseManager+ScopedDriver.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apple/Configs/NoExportedSymbols.exp). Nothing binds to their symbols: plugins are two-level, have no bundle loader, and load throughprincipalClass. Debug app builds keep their exports for the test bundle.withScopedDriver,withCancellableReadandwithTableReadDriverwrap the body once and run one boxed, non-generic lease chain, instead of a copy of the chain per result type.DescriptorReadandDescriptorWritemove from TableProUtilities to TableProProcess. TableProMCP and TableProCommandLine drop TableProUtilities, so both tools stop linking the SQL grammar, tabular IO and JavaScriptCore.DequeModuleand_RopeModuleproducts instead of theCollectionsumbrella.TableProFirebaseClient,TableProQdrantClientandTableProWeaviateClienttargets that only the registry plugins link..claude/rules/plugin-system.md: the R1 check runs on a Debug build or a Release dSYM, since Release plugins no longer keep symbols.no_dead_strip, so no Swift code goes away with the exports.MH_NOUNDEFSwith no DuckDB import.mainmedian 59.4 -> 54.1 ms; first frame 525 vs 527 ms.Not changed:
mainwith 1,168 images in 15.7 ms (median of 60) and 12.6 ms without AuthenticationServices and Charts (708 images). First frame spreads over 483 to 707 ms across launches, so 3 ms is under the noise.Needs the maintainer
no_dead_strip; only the hidden-Xfrontend -internalize-at-linklets ld drop unused public Swift code. Not used here.Test plan
LD_GENERATE_MAP_FILE=YES): sizes fromotool -l, per-module bytes from the link maps, icons fromassetutil --info.scripts/ci/verify-plugin-loads.shon the 16 bundled Release plugins and the 48 Debug plugins; R1 and R2 clean.swift testTableProCore: TableProProcessTests, TableProFirebaseCoreTests, TableProQdrantCoreTests, TableProWeaviateClientTests, 108 cases.