Repository navigation
fix(macos): give Teradata its answer for a failed statement in an open transaction - #4237
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
November 12, 2026 13:20
datlechin
added a commit
that referenced
this pull request
Nov 12, 2026
…lifts the timeout before its streams
datlechin
disabled auto-merge
November 12, 2026 15:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TransactionEngineFamily, and fix(drivers): keep Oracle values typed, fix Teradata ANSI transactions, complete SQL Server, Oracle and PostgreSQL DDL, and bound driver streams #4223 added.teradataafter them.failedStatementAbortsTransaction:.teradatajoins thefalsecases. That is what it answered before fix(drivers): keep Oracle values typed, fix Teradata ANSI transactions, complete SQL Server, Oracle and PostgreSQL DDL, and bound driver streams #4223, when it fell to.other, and it is right for an ANSI session, which rolls back only the failed request. A Teradata-mode (BTET) session rolls back the whole transaction, but the family cannot see the session's mode, so that stays as it was.AgentTransactionGuard.Savepoint.of:.teradatareturnsnil, since Teradata has no savepoint. Also unchanged from.other.Test plan
ManualCommitTests.agentProtectionFollowsTheFamilypins Teradata to no protection.ManualCommitTestson this change applied to a branch merged with current main.