Repository navigation
fix(core): end a DuckDB name where DuckDB's pass turns a non-ASCII space into a space - #4239
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SELECT varchar+ U+200B +E'\''; DROP TABLE t; --'was one statement to Safe Mode and two to DuckDB.Parser::StripUnicodeSpaces, from each statement's first code token, where the text the driver sends DuckDB starts.COMMIT.DROP, or checka+U+00A0+b.duckdbwhile DuckDB openeda b.duckdbthat another window had open.x$e'\'is a name and a plain string); a test pins it. Oracle and Dameng have no grammar in the core.Test plan
script_corpusDuckDB cases,statement_access(a text where DuckDB keeps one U+200B and blanks another was Read), the DuckDB driver's split,controls_transactionandmain_verb, the export integration test (the hiddenINSERTran), two ATTACH integration tests (the table was dropped; the held file was attached), the DuckDB history test, MCPsingle_batch. New, passing on main: the PostgreSQL case andserver_reading.verify.sh corefortablepro-core,tablepro-driver-duckdb,tablepro-mcpandtablepro-ffi; clippy and rustfmt; Windowsbuildandtest. Two DuckDB driver tests fail on macOS before and after (/proc/self/clear_refs,/private/varpaths).