Repository navigation
fix(editor): find literals in the cleaned text when removing invisible characters - #4240
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SELECT<NBSP>E'a\'<NBSP>b'on PostgreSQL becomesSELECT E'a\'<NBSP>b': the second NBSP is string data. Since fix(editor): end a name where the engine does before E'' and $$, keep a one-statement routine body from swallowing the script, and step Vim by character #4236 the remover read the raw text, where PostgreSQL continues the name through the NBSP, and cleaned inside the string.$$body after a non-ASCII blank, a line separator beforeE', and a removed character between a blank andE'.Test plan
InvisibleCharacterRemoverTests.postgresEscapeStringAndNestedCommentfails on main and passes here.dollarQuoteBehindABlankIsCode(from fix(editor): keep reading the keyword behind an invisible character #3025) pinned the raw reading, which rewrote a$$body the cleaned text runs as a string. NowdollarQuoteBehindABlankKeepsItsBody.lineSeparatorBeforeEscapeString,removedCharacterBeforeEscapeString.