Repository navigation
perf(windows): draw the caret as its own visual and add the row count and results per run settings - #4243
Merged
Conversation
… and results per run settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ElementCompositionPreview.SetElementChildVisualon the SwapChainPanel, oneSpriteVisualper visible caret, clipped at the gutter, snapped to pixels). A frame places them where it laid the text out; a blink, focus change or window activation only shows or hides the visual. WinUI's own TextBox keeps its caret in a child element too. ADR 0002 updated. (WIN-07)QueryRun::release_set; the one the grid shows stays until the run ends or another is picked. (FU-05)settings.json,countRowsIfEstimateLessThanandresultSetsKeptPerRun. An older build skips them; a file without them reads as 100,000 and no limit.Needs the maintainer
ShowFirstKept.Test plan
TheCaretStopsBlinkingAfterTheCaretTimeoutAndNoFrameFollowschanges on purpose, nowTheCaretBlinksWithNoFrameAndStopsAfterTheCaretTimeout: it asserted at least 2 frames while the caret blinked, it now asserts none while the visual toggles.TheCaretShowsOverTheTextAndTheBlinkHidesItreads the screen at the caret with it shown and hidden.TableTabCountTeststhreshold theory and refresh,RunResultsTestslimit cases,QueryTabTestssetting per run,StoreTestsround trips and files without the keys.AReleasedSetIsGoneFromTheRunAndAHandleStillHeldReadsOn. FFI:a_released_set_is_gone_from_the_run_and_the_later_sets_keep_their_index.ARunPastTheResultLimitKeepsTheNewestAndSaysHowManyWent.