Repository navigation
feat(share): share results and queries as public links from every app, masking sensitive columns first - #4253
Merged
Merged
Conversation
- Exclude rows pending deletion from a published snapshot. - Gate Share Result on the shared_links entitlement. - Guard both share paths against a double-click minting two links. - Cap the snapshot under the server's 5 MB compressed limit (4.5 MB uncompressed). - Map an unexpected AccountError to .server, not .offline.
…olumn names for secrets
… and the public read
datlechin
marked this pull request as draft
November 13, 2026 08:57
…he FFI, with the regenerated bindings
…://share links in a new query tab
…t when sharing it
# Conflicts: # core/docs/decisions/README.md
…rom the Vietnamese catalog
# Conflicts: # core/ARCHITECTURE.md # core/crates/core/src/masking/mod.rs # core/crates/core/src/sql_syntax/mod.rs # core/crates/ffi/src/masking.rs # core/docs/decisions/0028-data-masking.md # core/docs/decisions/README.md
# Conflicts: # windows/docs/decisions/0010-data-masking.md # windows/docs/decisions/README.md # windows/src/TablePro.Interop/Masking.cs # windows/tests/TablePro.Interop.Tests/MaskingTests.cs
# Conflicts: # linux/ARCHITECTURE.md # linux/crates/app/src/services/grid/grid_masks.rs # linux/crates/app/src/ui/connect_dialog/masking_section.rs # linux/crates/app/src/ui/editor/assistant_actions.rs # linux/crates/app/src/ui/workspace/session_watches.rs
…asswords and count share SQL in bytes
…sent, and refuse a share with no column
…Pro footer and refusals as macOS, and mark masked preview columns
…re, and send only an exact table count
…nt, off the main actor
… the rows a full snapshot sends
…the plan refuses, and a blank password
…for the sheets to check
…QL past 256 KB, worded as macOS
…L past 256 KB, worded as macOS
…re-read only when masking rules change
…ses one of only spaces
… never re-masks on sync
…, search and sort
datlechin
marked this pull request as ready for review
November 14, 2026 00:27
datlechin
enabled auto-merge (squash)
November 14, 2026 01:00
datlechin
disabled auto-merge
November 14, 2026 01:01
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v2/shares, tablepro-cloud Add custom database type icons throughout UI #17).tablepro://share?token=opens a shared query in a new tab and never runs it.tablepro-account, masking styles and detectors intablepro_core::masking, snapshot builder, FFI for Windows (ADRs 0027 and 0028).tooManyColumnsandtooLargeBlocksCreate(100 columns now share the first 100);ShareColumnChoiceTests.detectionCoversTheSentRowsbecamedetectionReadsPastTheBudget; the column secret warning lists only columns sent as they are.ShareErrorInvalid(validation errors now use the general sentence).Screenshots
Test plan