Repository navigation
fix(macos): read Teradata's BT and ET as transaction control only in its own grammar - #4259
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
November 13, 2026 01:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ManualCommitTests/teradataShortFormsControlTheTransactionfailed once fix(macos): commit Teradata DDL the app runs, stop Run All at DDL, and offer Commit when closing with an open transaction #4247 (ETin the catalog effect's transaction-end words) met perf(macos): keep inspector editors across rows, add results kept per run, treat a failed Teradata statement as aborting #4246, sinceETthen ended a transaction in every dialect.transactionShortForms, set only in Teradata's profile:BTandETare transaction control there and names everywhere else. Unknown engines do not read it.ET) and the batch plan (BT) read the fact; Manual Commit drops its own Teradata type check.SQLLexicalFeatureMappingTests(one more curated-only bit).Test plan
package TableProCore(TableProSQLGrammarTests, TableProTeradataCoreTests): 557 pass.ManualCommitTests(the failing case),SQLLexicalFeatureMappingTests,BatchCommitStatementTests,BatchTransactionPolicyTests,CatalogChangeClassifierTestsand the Teradata suites.SQLCatalogEffectClassifierTests.transactionShortFormsAreTeradatas, ET negatives inBatchCommitStatementTests.