Repository navigation
fix(ai): count one-item deletes as writes, keep Edit off service topics and ScyllaDB's audit log, pin dashboard tiles, and read MATCH_RECOGNIZE at Read-Only - #4262
Merged
Conversation
…cs and ScyllaDB's audit log, pin dashboard tiles, and read MATCH_RECOGNIZE at Read-Only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Leftovers of #4260 from the 2026-11-12 audit (SF-1, SF-2, SF-3).
auditkeyspace, where ScyllaDB 2026.1's table audit backend writesaudit.audit_log. On Cassandraauditstays a user keyspace, and the sidebar still lists it.PRODUCEinto a topic another service keeps its state in: a name starting with_(Schema Registry's_schemas, Confluent's internal topics) or., MirrorMaker 2's.internaltopics, Kafka Connect'sconnect-configs,connect-offsetsandconnect-status(the names Kafka ships inconnect-distributed.properties), and Kafka Streams'-changelogand-repartitiontopics. Neither the broker nor Schema Registry says which topics a worker or a registry was configured with, so only these names are read.DELETE ... WHERE id = 1, DynamoDB DeleteItem and MongoDB deleteOne already do, so Edit runs it. Covers Elasticsearch_doc, Typesense, a Qdrant delete of one point ID, Weaviate's class route, Firestore, Realtime Database nodes below a table, Bigtable, Memcacheddelete, etcddelwithout--prefix, and SurrealDBDELETE table:id. An index, a collection, a batch, a range, a prefix or a query stays destructive.PUTorPATCHthat replaces a top-level node now counts as destructive, since it drops every record under it."flush\x5fall"counts as theflush_allit runs.delwith a range end or--from-keyis refused; the driver used to drop them and delete only the first key./v1/objects/{class}/{id}. The class-less route deletes that UUID in every collection (Weaviate 1.40usecases/objects/delete.go).MATCH_RECOGNIZEruns. In its MEASURES and DEFINE,PREV,NEXT,FIRST,LAST,CLASSIFIERandMATCH_NUMBERare the clause's own,RUNNINGandFINALare keywords, and the row pattern (PERMUTEincluded) is syntax. Elsewhere, a nested query included, those names are user functions. A measure's alias and a DEFINE variable are no longer read as bare function names. A clause that does not read in Oracle's section order is read as before. DM8 has noMATCH_RECOGNIZE.execute_queryinstead ofconfirm_destructive_operation. An etcd plugin from before this change still refusesdel kin Edit until it updates with the next release.Tests changed on purpose:
EditModeDataCommandsRequestTests/dataDeleteIsListedButDestructive, nowoneItemDeleteRunsInEdit.EditModeDataCommandsCommandTests/memcachedDeleteIsData, nowmemcachedDeleteRunsInEdit;etcdKeepsEarlierRefusalsandetcdRunsDataWorkmovedel app/ato the commands Edit runs.EtcdCommandParserStatementPolicyTests:del /amoves from the delete lines to the write lines.QueryClassifierNonSqlTests:etcdTiers,etcdDestructiveSubcommands,memcachedTiers,typesenseTiers,bigtableTiers,firebaseTiers,firebaseWritesThatDelete,firebaseMetadataOnlyWritesDelete,firebasePathStartingWithMarkandrequestTextTiersWhatTheDriverReceivesfollow the one-item rule and the Realtime Database table rule.Docs: TableProApp/docs#233
Test plan
package TableProCore: TableProSQLGrammarTests (531, new SurrealRecordDeleteTests, MATCH_RECOGNIZE cases in SQLReadOnlyFunctionCallsTests and SQLBareNameCallsTests, ScyllaDB audit in SQLDataStatementTests), WeaviateStatementGeneratorTests, and the Kafka, Bigtable, Firebase, Qdrant and Memcached core targets pass.testwith the Edit mode suites, ExternalStatementGateTests, QueryClassifierNonSqlTests, QueryClassifierOneItemDeleteTests, EtcdCommandParser suites, DashboardTileBoardTests, DashboardTileSessionTurnTests (a tile waits for a held session turn and runs pinned to the checked schema; a cancelled tile reaches the driver's cancel), ReadOnlySafeModeEntryPointTests and ExecutionGateTests: 435 pass.pluginspasses.apple/scripts/probes/check-match-recognize-calls.shon Oracle 23.26.3 (gvenzl/oracle-free) agrees with the reading; on DM8 (2023-04 build)MATCH_RECOGNIZEis a syntax error.