Repository navigation
fix(macos): end a COPY at once on Stop and move the SQL import bar with the bytes read - #4263
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancelCurrentQueryno longer sends its own queued cancel request while a copy-in runs, for the same reason.apple/scripts/probes/check-postgresql-copy-in.sh: Stop cases added. libpq 17.4 against PostgreSQL 17.11 and 18.6: a Stop mid-stream ends in 30 to 300 ms (CopyFail alone took up to 1.4 s with rows in buffers); during a row lock wait CopyFail alone stays unanswered, and one cancel request ends it in about 300 ms; the session runs the next statement, an open block is left aborted, no row stays.Test plan
LibPQCopyInTestsstopReachesAServerThatTakesNoData(scripted server that reads nothing until a cancel request; the old blocking loop never ends the copy) andstopBeforeTheCopyStarts;stopEndsTheCopynow stops throughcancelCurrentQueryand checks that no cancel request was sent.ImportRunTests(Stop during, before and after a COPY, teardown),ImportDataSinkAdapterCopyTests.stopCancelsTheCopy,SQLFileParserBytesReadTests,ImportStateTransferProgressTests,TransferProgressTests.fileFractionDrivesTheBar.verify.sh teston the 13 suites around import and copy-in: 163 passed. Build, plugins and lint pass.