Repository navigation
perf(macos): free each chunk the SQL import parser reads instead of holding the whole file - #4279
Merged
Merged
Conversation
…, statement and COPY piece
datlechin
enabled auto-merge (squash)
November 13, 2026 15:51
datlechin
disabled auto-merge
November 13, 2026 16:23
datlechin
enabled auto-merge (squash)
November 13, 2026 16:23
datlechin
disabled auto-merge
November 13, 2026 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance audit 2026-11-11, MEM-02 rest (the parser part #4212 left for after #4210).
readData(ofLength:), an autoreleasedNSData. A statement count, the SQL Server GO scan and a driver reading aCOPY ... FROM STDINsection run many reads with nothing draining the thread's pool, so every chunk, and with the MySQL grammar every statement's text, stayed alive until the scan ended and for a while after.readChunk), one per statement cut (readNextStatement), one perCOPYpiece (nextRowsPiece).read(upToCount:), which throws on a read error.readData(ofLength:)raises an Objective-C exception there, which quits the app. Same change for the Import dialog's preview read.phys_footprintsampled every 1 ms:.sql.gz(decompress + count)COPYrows read on a driver queueCOPYCOPYbytes in every case.Test plan
SQLFileParserTests: an empty file, a last statement with no;when the file ends on a full read chunk, a UTF-8 file cut inside its last character. They pin end-of-file behavior across the read change, so they pass on main too.SQLFileParser*Tests,SQLScriptTextTests,ImportStatementCountTests) and the import suites (SqlFileImportSource*Tests,ImportService*Tests,ImportExecutionGateTests), 221 tests, all pass.