Skip to content

fix(ci): draw no editor frame on focus loss, show one WinUI test window at a time, check ClickHouse's port, update Flatpak runtimes on a volume - #4284

Merged
datlechin merged 2 commits into
mainfrom
fix/main-ci-red
Nov 14, 2026
Merged

datlechin merged 2 commits into
mainfrom
fix/main-ci-red

Conversation

@datlechin

@datlechin datlechin commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Windows editor: focus leaving the editor draws no frame when no IME composition is shown. WinUI raises LostFocus when another window takes the activation, and TsfInput.Unfocus cleared an empty composition with a full frame: the extra frame in TheCaretBlinksWithNoFrameAndStopsAfterTheCaretTimeout on x64.
  • Windows tests: tests/Shared/WinUiApp.cs holds a named mutex, so the editor and grid test processes, which dotnet test runs at once, never show windows together. In every failing run, TablePro.DataGrid.Tests opened its window in the caret test's last second.
  • New caret tests: focus moving to a button and back, and another window taking the activation and giving it back, draw no frame. ADR 0002 records the LostFocus behavior with the run id.
  • Windows UI tests: a status's text is read through AppSession.TextOf, which gives an empty string where FlaUI's Name throws. A status has no UIA Name while its text is empty, so RunStatementRunsOnlyTheStatementAtTheCursorAndSelectsIt threw PropertyNotSupportedException on Arm64 in this PR's rerun; ten checks read a status that way.
  • ClickHouse fixture test: checks that the server listens for HTTP on port 8124, at any address. The 26.8 tag moved to 26.8.37.168 on 2026-11-14, which binds ::; 26.8.36.3 and 26.3 bind 0.0.0.0.
  • Flatpak Devel: /var/lib/flatpak lives on a named Docker volume. On AWS-hosted runners, updating a runtime in the image layer fails with "Invalid cross-device link": every AWS job failed, every Azure job without a cache passed, and a rerun with no cache failed too.

Test plan

  • Probe run 43614838421 (x64, 3 passes): both new caret tests fail on main, Expected 0, Actual 1, each after LostFocus → ShowComposition → frame. Run 43615345331 with the fix: no frame, every editor test passes 3 of 3.
  • Probe run 43615225881, two attempts: the image-layer update failed on 1 of 1 AWS runner and passed on 7 of 7 Azure ones; on the volume it passed on 8 of 8 (4 AWS, 4 Azure), in 38 to 51 s against 80 to 99 s.
  • cargo test -p tablepro-test-fixtures --lib clickhouse_fixture::tests -- --include-ignored with Docker: the old assertion fails on 26.8, the new one passes on 26.8 and 26.3.
  • verify.sh --platform windows build: PASS.
  • windows / Windows (x64) on this PR, run three times.

@datlechin
datlechin merged commit 3811cbf into main Nov 14, 2026
35 of 36 checks passed
@datlechin
datlechin deleted the fix/main-ci-red branch November 14, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant