Repository navigation
fix(ci): draw no editor frame on focus loss, show one WinUI test window at a time, check ClickHouse's port, update Flatpak runtimes on a volume - #4284
Merged
Conversation
…ow at a time, check ClickHouse's port, update Flatpak runtimes on a volume
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TsfInput.Unfocuscleared an empty composition with a full frame: the extra frame inTheCaretBlinksWithNoFrameAndStopsAfterTheCaretTimeouton x64.tests/Shared/WinUiApp.csholds a named mutex, so the editor and grid test processes, whichdotnet testruns at once, never show windows together. In every failing run,TablePro.DataGrid.Testsopened its window in the caret test's last second.AppSession.TextOf, which gives an empty string where FlaUI'sNamethrows. A status has no UIA Name while its text is empty, soRunStatementRunsOnlyTheStatementAtTheCursorAndSelectsItthrewPropertyNotSupportedExceptionon Arm64 in this PR's rerun; ten checks read a status that way.26.8tag moved to 26.8.37.168 on 2026-11-14, which binds::; 26.8.36.3 and 26.3 bind0.0.0.0./var/lib/flatpaklives on a named Docker volume. On AWS-hosted runners, updating a runtime in the image layer fails with "Invalid cross-device link": every AWS job failed, every Azure job without a cache passed, and a rerun with no cache failed too.Test plan
LostFocus→ShowComposition→ frame. Run 43615345331 with the fix: no frame, every editor test passes 3 of 3.cargo test -p tablepro-test-fixtures --lib clickhouse_fixture::tests -- --include-ignoredwith Docker: the old assertion fails on 26.8, the new one passes on 26.8 and 26.3.verify.sh --platform windows build: PASS.windows / Windows (x64)on this PR, run three times.