Repository navigation
fix(windows): ask a question that comes while the last dialog is still closing - #4290
Merged
Merged
Conversation
…l prompt unshown while a dialog closes
… it is shown or cancelled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WindowDialogscounted an answered dialog as open untilShowAsyncreturned, which WinUI does only after the closing transition (210 to 350 ms on the Arm64 runner). A question asked in that time was declined as Cancel: Roll back clicked right after cancelling the close prompt did nothing, and Alt+F4 in that time was dropped.Closing. A question asked during the transition waits for it and keeps its turn until it is shown, ahead of a queued shared-link prompt.CancellingCloseSelectsTheConnectionWhoseTransactionWasShownfailed for this reason; the test was right and is unchanged.RollBackRightAfterCancellingCloseStillAsks.PressDialogButtontakes an optional button name, to tell the new dialog from one still closing.Test plan
windows-11-arm, 15 passes per theme of the test's steps with the app logging each dialog: the close prompt'sShowAsyncreturned 210 to 350 ms afterClosing, and Roll back came 3 to 213 ms after that (run 43643257678).RollBackRightAfterCancellingCloseStillAsksadded: on the old code it failed 20 of 20 with the app logging the roll back prompt as declined (run 43645046133). With this change both tests passed 40 of 40 on main and on feat(windows): production cue, database switchers, find and replace, sql files, redis key tab, cassandra paging and display settings #4285's head (runs 43645911845, 43645919130).