Skip to content

fix(windows): ask a question that comes while the last dialog is still closing - #4290

Merged
datlechin merged 6 commits into
mainfrom
fix/windows-close-dialog-flake
Nov 15, 2026
Merged

datlechin merged 6 commits into
mainfrom
fix/windows-close-dialog-flake

Conversation

@datlechin

@datlechin datlechin commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Summary

  • WindowDialogs counted an answered dialog as open until ShowAsync returned, which WinUI does only after the closing transition (210 to 350 ms on the Arm64 runner). A question asked in that time was declined as Cancel: Roll back clicked right after cancelling the close prompt did nothing, and Alt+F4 in that time was dropped.
  • A dialog now stops counting as open at Closing. A question asked during the transition waits for it and keeps its turn until it is shown, ahead of a queued shared-link prompt.
  • The credential prompt passes its cancellation token, so a connect cancelled during that wait shows no prompt.
  • CancellingCloseSelectsTheConnectionWhoseTransactionWasShown failed for this reason; the test was right and is unchanged.
  • New UI test RollBackRightAfterCancellingCloseStillAsks. PressDialogButton takes an optional button name, to tell the new dialog from one still closing.
  • Decision 0004 records the rule and the runner timing.

Test plan

@datlechin
datlechin merged commit 1b1ad09 into main Nov 15, 2026
14 of 16 checks passed
@datlechin
datlechin deleted the fix/windows-close-dialog-flake branch November 15, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant