Repository navigation
refactor(macos): pass the caller's schema to DDL generators, drop the driver adapter downcasts and move the parts pane behind a plugin capability - #4294
Merged
Conversation
… driver adapter downcasts and move the parts pane behind a plugin capability
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sp_renameparses.as? PluginDriverAdapterleft inTablePro/.DatabaseDrivergainsplugin,sessionQueryTimeoutSeconds,truncateTableStatements,dropObjectStatement,streamRowsandstreamExportRows.tableOperationEligibilitymoves onto the protocol. The adapter's pure PluginKit forwards are gone. A SwiftLint rule refuses a new cast.PluginStorageParts. The ClickHouse plugin owns thesystem.partsread and the OPTIMIZE, DROP and DETACH PARTITION statements. The pane shows for any driver that answers it, not for a type check.DatabaseDriver).Test plan
PostgreSQLDDLSchemaQualificationTests: every generator names the given schema; nil falls back to the session's.MSSQLSchemaQueriesTests: a schema named[dbo]or a table with a quote stays inside its own bracketed part.PluginSchemaDDLDefaultsTests: a driver with only the schema-less generators answers the new overloads.SchemaSyncTargetSchemaTests: Compare & Sync and a Structure save name the target schema.DatabaseDriverPluginSurfaceTests: the adapter witnesses each lifted member through the protocol; a double answers none.StructureServerSupportTests,StructureAvailabilityTests,StoragePartsGridTests,ClickHousePartStatementsTests: the Parts pane follows the capability.verify.sh plugins,abi(changed, kit 45, minimum 19),ios ConnectionCoordinatorCatalogTestsandlint.Refs #4272