Repository navigation
test(core): dial port 1 where a test wants a refused connect - #4301
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tablepro-account(unreachable(),a_network_failure_never_words_the_share_token),tablepro-ffiandTablePro.Interop.Testsaccount tests,tablepro-ai,tablepro-cli,tablepro-net(dial, TLS probe), the ClickHouse editor run and the MongoDB replica set test.dropped_port_then_live_listener_connects_secondtorefused_port_then_live_listener_connects_second.logfeature, which the advisory requires.Test plan
cargo test -p tablepro-account --liblooped 60 times on macOS: 60 passed.tablepro-net,tablepro-ai,tablepro-driver-clickhouseandtablepro-clipass on macOS.tablepro-accountlib andAccountTestson Windows x64, Windows Arm64 and macOS; on Linux the account lib,tablepro-ffiaccount, net dial and TLS probe, ClickHouse editor run, AI providers and CLI tests. https://github.com/TableProApp/TablePro/actions/runs/43791277582Needs the maintainer
linux/crates/app/src/ui/preferences_dialog/account_page.rs(ready()) has the same pattern; left for after the Linux 0.1.0 soak.