Repository navigation
feat(windows): keep filters per table, filter by a cell, truncate and drop tables, create and drop schemas and databases, export progress - #4304
Merged
Conversation
… drop tables, create and drop schemas and databases, export progress
…e for export, refuse repeated INSERT columns
…between databases, read a cell's filter text only when it is offered
… own schemas, close tabs of every dropped object, reload filter choices after a refresh
… tabs after a cascading schema drop, refuse INSERT names equal but for case
…a computed-only result's values
…cell menu whose cell moved while it loaded
…one schema's folders its commands
…a centres with no replicas
… a trigger tab by its table, keep the server's own database from a drop
…efore asking to discard its edits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
table-filters.json) and comes back, applied, when the table opens again. Clear forgets it; a drop forgets it.=,!=,>and<where the column orders,is NULL/is not NULLfor a NULL cell. The rule joins the running filter and applies at once.query_resultsas macOS does; a result naming one column twice is refused. The export bar shows the rows written so far, out of the total where known.catalog_abilities,plan_catalog_change->CatalogChange(statements, Safe Mode gate, run once, re-planned and compared on the lease),database_choices,protects_database/protects_schema,refresh_schemas,TableKeys.referencing_tables, andExportProgressonexport_rows/export_table. Bindings regenerated.sql_insert_without_a_table_is_refused_before_any_file(Rust) andSqlInsertWithoutATableIsRefusedBeforeAnyFile(C#) now check the query result's INSERT target;AQueryResultExportsTheRowsShownInEveryFormatButSqlInsertnow expects SQL INSERT.windows/AGENTS.mdinterop bullet.Test plan
cargo test -p tablepro-ffi: newtests/catalog_change.rs(SQLite truncate and drop, DuckDB schema create and drop, Safe Mode change refusal) and export tests (query result INSERT, repeated column names, progress count).TablePro.Interop.Tests:CatalogChangeTests,ExportTests(progress while running, query result INSERT).TablePro.App.Model.Tests:TableFilterMemoryTests,CellFiltersTests,TableTabFilterTests(kept per table, refused filter not kept, cell rule),WorkspaceTabsTests(dropped table's tab closes without asking).CatalogTests.cs(filter by cell and kept on reopen, truncate refused / truncate / drop, export choice for a query result, PostgreSQL fixture: New database dialog, schema create and drop).Screenshots
After (from the x64 UI tests; none of these surfaces existed before).