Skip to content

feat(windows): keep filters per table, filter by a cell, truncate and drop tables, create and drop schemas and databases, export progress - #4304

Merged
datlechin merged 16 commits into
mainfrom
feat/windows-core-wave-3
Nov 16, 2026
Merged

datlechin merged 16 commits into
mainfrom
feat/windows-core-wave-3

Conversation

@datlechin

@datlechin datlechin commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Summary

  • W-15: a table's last applied filter is kept per connection, database, schema and table (table-filters.json) and comes back, applied, when the table opens again. Clear forgets it; a drop forgets it.
  • W-16: a table tab's cell menu has Filter: =, !=, > and < where the column orders, is NULL / is not NULL for a NULL cell. The rule joins the running filter and applies at once.
  • W-45: SQL INSERT is offered for a query result, written into query_results as macOS does; a result naming one column twice is refused. The export bar shows the rows written so far, out of the total where known.
  • W-09: the object menu adds Open in new tab, Show DDL, Truncate... and Drop.... Each dialog shows the core's statements for its options (Cascade, Restart identity, cluster). A table other tables' keys point at is refused up front where the engine requires it.
  • W-10: New schema... and Drop schema on schema rows, New database... and Drop database on the database switcher, schema rows (MySQL-style layouts) and the Database menu. The New database dialog shows the options the engine names, filled from the server's choices.
  • Core FFI: catalog_abilities, plan_catalog_change -> CatalogChange (statements, Safe Mode gate, run once, re-planned and compared on the lease), database_choices, protects_database / protects_schema, refresh_schemas, TableKeys.referencing_tables, and ExportProgress on export_rows / export_table. Bindings regenerated.
  • Refresh now reads the schemas again, so a schema made or dropped in the editor shows.
  • Tests changed on purpose: sql_insert_without_a_table_is_refused_before_any_file (Rust) and SqlInsertWithoutATableIsRefusedBeforeAnyFile (C#) now check the query result's INSERT target; AQueryResultExportsTheRowsShownInEveryFormatButSqlInsert now expects SQL INSERT.
  • Docs: Windows ADR 0012, 0007 amended, core 0022 export line, windows/AGENTS.md interop bullet.
  • Waits on C-05: staging truncate/drop until Save (macOS), and Drop for views, materialized views, foreign tables and sequences (the core plans DROP TABLE only).

Test plan

  • cargo test -p tablepro-ffi: new tests/catalog_change.rs (SQLite truncate and drop, DuckDB schema create and drop, Safe Mode change refusal) and export tests (query result INSERT, repeated column names, progress count).
  • TablePro.Interop.Tests: CatalogChangeTests, ExportTests (progress while running, query result INSERT).
  • TablePro.App.Model.Tests: TableFilterMemoryTests, CellFiltersTests, TableTabFilterTests (kept per table, refused filter not kept, cell rule), WorkspaceTabsTests (dropped table's tab closes without asking).
  • UI tests with screenshots: CatalogTests.cs (filter by cell and kept on reopen, truncate refused / truncate / drop, export choice for a query result, PostgreSQL fixture: New database dialog, schema create and drop).

Screenshots

After (from the x64 UI tests; none of these surfaces existed before).

Filter menu on a cell
Filter by a cell applied
Filter by a cell applied, dark
Filter back when the table opens again
Truncate refused for a referenced table
Truncate question
Drop question
Drop question, dark
SQL INSERT for a query result
New database
New database, dark
New schema
Drop schema

… drop tables, create and drop schemas and databases, export progress
…e for export, refuse repeated INSERT columns
…between databases, read a cell's filter text only when it is offered
… own schemas, close tabs of every dropped object, reload filter choices after a refresh
… tabs after a cascading schema drop, refuse INSERT names equal but for case
… a trigger tab by its table, keep the server's own database from a drop
@datlechin
datlechin merged commit a655760 into main Nov 16, 2026
35 of 36 checks passed
@datlechin
datlechin deleted the feat/windows-core-wave-3 branch November 17, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant