Repository navigation
fix(linux): stop the command line refusing the app before it accepts the connection - #4311
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loopback_peer_is_ourson Linux: a server-side connection still waiting to be accepted has no inode in/proc/net/tcp, and kernels before 6.17 list it as root's. It now takes the owner of the LISTEN socket on the same address, only for ESTABLISHED and SYN_RECV rows; a closing socket with no inode is never attributed to a listener.tablepro(the command line) refused the running app as a foreign server when it checked before the app accepted the connection, on kernels before 6.17. This failedcommand_line::linux_host::tests::a_listener_this_process_owns_is_verifiedin every Launchpad PPA build of linux-v0.1.0-beta.4.proc_net_tcp.rsbecome plain comments.Test plan
proc_net_tcptests: a crafted table as kernel 6.8 lists an unaccepted connection (ours, another user's listener, no listener), and another user's closed connection at an address a listener of ours took later (refused).a_connection_waiting_to_be_accepted_is_its_ownand the existing Linux host test run on Linux CI.