Repository navigation
Conversation
…rt-result-edit # Conflicts: # windows/docs/decisions/README.md # windows/src/TablePro.App/Strings/en-US/Resources.resw # windows/src/TablePro.Interop/Generated/tablepro_ffi.cs # windows/src/TablePro.Interop/TableProCore.cs
…after a held sort
… read rows again after every save
datlechin
enabled auto-merge (squash)
November 18, 2026 08:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ForeignHost::data_protection; DataGrip'sCRYPT_32KeePass main key opens through it, then asBUILT_IN.Core::foreign_sourcesandCore::read_foreigngive aForeignImportReview(rows, notes, choices, resolve, apply once under the library write lock, passwords into the core's secret store, saved queries into the history store). Windows host passes DPAPICryptUnprotectData.DatabaseSession::result_editor(sql, rows)gives aTableEditorover a query result, one column per result column, locked with anEditLockreason (NotOneSelect,MoreThanOneTable,Collapsed,Untraced,KeyNotShown, ...). Edits name rows of that one result set only.TableEditor::table()andcopies_exactly(rows, row), so a row read as PostgreSQL server text for a float, a time or money is not duplicated.TableProCore.GetForeignSourcesAsync/ReadForeignAsync,ForeignImportReview,DatabaseSession.OpenResultEditorAsync,TableEditor.Table, regenerated bindings..ncxvia the open picker.TableTabintoEditedRows, shared by both tabs.windows/AGENTS.md.Screenshots
New surfaces, from the Windows (x64) UI tests; before this change neither the dialog nor the result's edit commands existed.
Test plan
core/crates/ffi/tests/result_edits.rs: a keyed result saves an update, insert and delete; a repeated column stays out of every statement; each lock; rows of another set, the same SQL run again included, refuse; a sorted view of the result saves.core/crates/ffi/tests/foreign_import.rs: a DBeaver connection lands once with its password and script; a second read matches and keeps the saved one; an outdated library refuses; missing apps fail with their codes.foreign-importunit tests: aCRYPT_32key opens through data protection, another user's blob stops, a legacypdb.pwdon Windows opens. Windows-only DPAPI round trip inforeign_import.rs.ResultEditTests,ForeignImportTestsagainst real SQLite and DBeaver files.QueryTabEditingTests(refusals, save and re-read, held sort, close paths, copies),ForeignImportFormTests; the existingTableTab*tests pass unchanged (731 pass).ResultEditingTests(edit, save, re-run; grouped result says why),ImportFromAppTests(Navicat export into the library), with screenshots from CI.verify.sh: build, core (ffi 279, foreign-import 501), bindings, Interop and App.Model tests pass on macOS;cargo xwin clippyfor x86_64-pc-windows-msvc is clean.linux / Supply chainfails on RUSTSEC-2026-0543 (chrono unmaintained), a new advisory that is not this change's.Part of #4275: WN-08. WN-09 (completion) stays open.