fix: 상세 탐색 키워드 검색창 터치 영역 및 아이콘 크기 시안 불일치 - #956
Merged
Merged
Conversation
- 삭제/검색 아이콘을 36dp 버튼으로 감싸 터치 영역을 확보한다 - 검색 아이콘 크기를 25dp로, 컨테이너 높이와 좌우 패딩을 시안에 맞춘다
|
Warning Review limit reachedNext included review available in 43 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
https://discord.com/channels/1185753783020568648/1537808439965786192
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
디자인 QA로 접수된 키워드 검색창 이슈를 수정했습니다.
기존에는 아이콘에
Modifier.size()와clickableWithoutRipple을 함께 걸어 아이콘 크기가 곧 터치 영역이었습니다. 시안 구조대로 아이콘을 36dp 버튼 안에 배치하도록KeywordSearchFieldButton을 분리했습니다.📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
X 버튼 터치 영역 — 검색어 입력 상태에서
x=1116..1224= 36dp 확인동작 — X 탭 시 입력이 지워지고 placeholder로 복귀하는 것까지 확인했습니다.
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴