Skip to content

fix: restore macOS local build and publish from the csproj - #352

Merged
patchzyy merged 2 commits into
TeamWheelWizard:mainfrom
gingerbeardman:fix/macos-publish-csproj
Sep 1, 2026
Merged

fix: restore macOS local build and publish from the csproj#352
patchzyy merged 2 commits into
TeamWheelWizard:mainfrom
gingerbeardman:fix/macos-publish-csproj

Conversation

@gingerbeardman

@gingerbeardman gingerbeardman commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Purpose of this PR

The macOS release jobs added in #326 run ./macos/release-macos.sh from the repo root. That script called dotnet publish with no project path, so the CLI picks up WheelWizard.sln. The solution only defines Debug|Any CPU and Release|Any CPU, so -c Release-macOS fails with MSB4126 and no .app / DMG is produced.

I hit this while building locally after that merge. The next v* tag would ship without macOS assets.

#326 also removed the root build-mac.sh that sat next to build-linux.sh / build-win.bat. Those Windows and Linux scripts are local-dev helpers (CI inlines dotnet publish for those platforms). Restoring a root build-mac.sh that delegates to macos/release-macos.sh brings macOS back in line.

How to Test

On macOS, from the repo root:

./build-mac.sh
# or
./macos/release-macos.sh

Expected: a .app at release/WheelWizard.app, not:

MSB4126: The specified solution configuration "Release-macOS|Any CPU" is invalid

Optional: BUILD_ARCH=x64 ./build-mac.sh for an Intel build.

CI: the macos-arm64 and macos-x64 jobs in .github/workflows/release.yml should get past the "Build .app bundle" step.

What Has Been Changed

  • macos/release-macos.sh now publishes WheelWizard/WheelWizard.csproj instead of the solution, matching the Windows and Linux dotnet publish steps in the release workflow.
  • Restored root build-mac.sh as a local entry point that runs macos/release-macos.sh (same role as build-linux.sh / build-win.bat).

Related Issue

None — found while building locally after #326.

Summary by CodeRabbit

  • New Features

    • Added a macOS build entry point that can be run from any directory.
    • Improved build reliability by using an explicit project path and forwarding command-line options.
  • Bug Fixes

    • Prevented macOS packaging builds from failing when started outside the project directory.

dotnet publish from the repo root picks up WheelWizard.sln, which only
defines Debug|Any CPU and Release|Any CPU. -c Release-macOS then fails
with MSB4126, so the macOS release jobs from TeamWheelWizard#326 cannot produce a .app.

Point the publish at WheelWizard/WheelWizard.csproj, matching the
Windows and Linux release steps.
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a9172fd8-c5ed-432f-99db-adeb36428676

📥 Commits

Reviewing files that changed from the base of the PR and between 220ce0b and 05e6402.

📒 Files selected for processing (2)
  • build-mac.sh
  • macos/release-macos.sh

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The macOS build now provides a strict wrapper that locates and executes the release script. The release script publishes WheelWizard.csproj through an explicit path instead of relying on the current working directory.

Changes

macOS publish flow

Layer / File(s) Summary
Add the macOS build wrapper
build-mac.sh
The wrapper enables strict shell error handling, resolves its own directory, forwards arguments, and executes macos/release-macos.sh.
Publish the WheelWizard project
macos/release-macos.sh
dotnet publish now uses $WW_DIR/WheelWheel/WheelWizard.csproj directly. The script no longer changes to $WW_DIR before publishing or returns to $SCRIPT_DIR afterward.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 05e64

The macOS publish command now targets the project directly and the local wrapper restores the expected entry point; no actionable merge-blocking risk remains after normal checks.

Poem

A rabbit hops through scripts bright

The path stays firm from left to right
Strict errors guard each tiny track
The project file leads the pack
Build flags ride and won't turn back

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the two main changes: restoring the macOS local build and publishing from the project file.
Description check ✅ Passed The description explains the purpose, testing steps, changes, expected result, CI impact, and related issue status. It is complete enough for review. The section headings omit some template punctuatio…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the purpose, testing steps, changes, expected result, CI impact, and related issue status. It is complete enough for review. The section headings omit some template punctuation, and the test checklist remains unchecked, but these are minor issues.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Windows and Linux still have root-level publish scripts for local
builds; CI does not use them. Restore a matching entry point that
delegates to macos/release-macos.sh so ./build-mac.sh produces a
.app again.
@gingerbeardman gingerbeardman changed the title fix: publish macOS release from the csproj, not the solution fix: restore macOS local build and publish from the csproj Aug 31, 2026
@patchzyy
patchzyy merged commit 1ee8177 into TeamWheelWizard:main Sep 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants