Repository navigation
Conversation
Forward api.wire_api, supports_websockets, and supports_standalone_web_search onto the Codex model provider used for a custom endpoint. Co-authored-by: Irrelevant <owenqwenstarsky@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ff536d5eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "supports_standalone_web_search=" | ||
| f"{self._toml_bool(api.supports_standalone_web_search)}" |
There was a problem hiding this comment.
Use a Codex-supported web-search setting
When api.supports_standalone_web_search is set, _codex_custom_provider_literal emits a provider key that Codex does not recognize, so Teich's normal non-strict invocation silently ignores it and the advertised web-search opt-in never occurs. I checked Codex CLI 0.144.0-alpha.4 installed in this environment: codex --help describes --strict-config as “Error out when config.toml contains fields that are not recognized,” and running the generated model_providers.gateway table in that mode reports unknown configuration field model_providers.gateway.supports_standalone_web_search (while supports_websockets is accepted); codex features list instead exposes standalone_web_search as a feature. Please map this option to a supported Codex mechanism or remove it until the runtime actually exposes the provider capability.
Useful? React with 👍 / 👎.
Show wire API and the websocket and standalone web search toggles on the Configure page when Codex is selected, and save them into config.yaml. Co-authored-by: Irrelevant <owenqwenstarsky@users.noreply.github.com>
|
Great feature addition, thanks! |
Forward api.wire_api, supports_websockets, and supports_standalone_web_search onto the Codex model provider used for a custom endpoint.