Skip to content

Let Codex custom providers opt into websockets and web search. - #37

Merged
armand0e merged 2 commits into
TeichAI:mainfrom
owenqwenstarsky:cursor/codex-provider-capabilities-0ad1
Oct 15, 2026
Merged

armand0e merged 2 commits into
TeichAI:mainfrom
owenqwenstarsky:cursor/codex-provider-capabilities-0ad1

Conversation

@owenqwenstarsky

Copy link
Copy Markdown
Contributor

Forward api.wire_api, supports_websockets, and supports_standalone_web_search onto the Codex model provider used for a custom endpoint.

Forward api.wire_api, supports_websockets, and supports_standalone_web_search onto the Codex model provider used for a custom endpoint.

Co-authored-by: Irrelevant <owenqwenstarsky@users.noreply.github.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T00:07:47.808216Z 8ff536d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ff536d5eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/teich/runner.py
Comment on lines +2874 to +2875
"supports_standalone_web_search="
f"{self._toml_bool(api.supports_standalone_web_search)}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use a Codex-supported web-search setting

When api.supports_standalone_web_search is set, _codex_custom_provider_literal emits a provider key that Codex does not recognize, so Teich's normal non-strict invocation silently ignores it and the advertised web-search opt-in never occurs. I checked Codex CLI 0.144.0-alpha.4 installed in this environment: codex --help describes --strict-config as “Error out when config.toml contains fields that are not recognized,” and running the generated model_providers.gateway table in that mode reports unknown configuration field model_providers.gateway.supports_standalone_web_search (while supports_websockets is accepted); codex features list instead exposes standalone_web_search as a feature. Please map this option to a supported Codex mechanism or remove it until the runtime actually exposes the provider capability.

Useful? React with 👍 / 👎.

Show wire API and the websocket and standalone web search toggles on the Configure page when Codex is selected, and save them into config.yaml.

Co-authored-by: Irrelevant <owenqwenstarsky@users.noreply.github.com>
@armand0e

Copy link
Copy Markdown
Collaborator

Great feature addition, thanks!

@armand0e
armand0e merged commit 9d27655 into TeichAI:main Oct 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants