Skip to content

fix(parser): ignore CSI sequences with a private prefix in SGR #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Heal75 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(parser): ignore CSI sequences with a private prefix in SGR #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/src/core/escape/parser.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,9 @@ class EscapeParser {
///
/// https://terminalguide.namepad.de/seq/csi_sm/
void _csiHandleSgr() {
// `CSI > Ps m` (XTMODKEYS) and `CSI ? Ps m` are not SGR.
if (_csi.prefix != null) return;

final params = _csi.params;

if (params.isEmpty) {
Expand Down
19 changes: 19 additions & 0 deletions test/src/core/escape/parser_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,24 @@ void main() {
parser.write('\x1b[8;24;80t');
verify(parser.handler.resize(80, 24));
});

test('does not treat CSI > Ps m as SGR', () {
final parser = EscapeParser(MockEscapeHandler());
// XTMODKEYS, e.g. sent by programs enabling modifyOtherKeys.
parser.write('\x1b[>4m');
verifyNever(parser.handler.setCursorUnderline());
});

test('does not treat CSI ? Ps m as SGR', () {
final parser = EscapeParser(MockEscapeHandler());
parser.write('\x1b[?4m');
verifyNever(parser.handler.setCursorUnderline());
});

test('still parses plain SGR', () {
final parser = EscapeParser(MockEscapeHandler());
parser.write('\x1b[4m');
verify(parser.handler.setCursorUnderline()).called(1);
});
});
}